Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly add enabled: true in the galera sample #647

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Jan 31, 2024

In the DP3 content galera is not enabled by default. This patch adds the missing boolean to make sure we don't be blocked by kubebuilder during the CR creation.

In the DP3 content galera is not enabled by default.
This patch adds the missing boolean to make sure we
don't be blocked by kubebuilder during the CR creation.

Signed-off-by: Francesco Pantano <[email protected]>
@fmount fmount requested a review from abays January 31, 2024 15:50
@openshift-ci openshift-ci bot requested a review from olliewalsh January 31, 2024 15:50
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b79b65973da3427eae2ac56f4568319d

openstack-k8s-operators-content-provider ERROR Project github.com/openstack-k8s-operators/dataplane-operator does not have the default branch master in 9s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@abays
Copy link
Contributor

abays commented Feb 1, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5e0dfd66f2f340008bd320e04f286145

openstack-k8s-operators-content-provider ERROR Project github.com/openstack-k8s-operators/dataplane-operator does not have the default branch master in 9s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@fmount
Copy link
Contributor Author

fmount commented Feb 1, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/c59194344a684e1ea40e656dcb7f020f

openstack-k8s-operators-content-provider ERROR Project github.com/openstack-k8s-operators/dataplane-operator does not have the default branch master in 11s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

Copy link

@agarcia64 agarcia64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this change in my environment

Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

@agarcia64: changing LGTM is restricted to collaborators

In response to this:

I verified this change in my environment

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, agarcia64, fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abays abays merged commit 03d8437 into openstack-k8s-operators:dev-preview3 Feb 6, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants