-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly add enabled: true in the galera sample #647
Explicitly add enabled: true in the galera sample #647
Conversation
In the DP3 content galera is not enabled by default. This patch adds the missing boolean to make sure we don't be blocked by kubebuilder during the CR creation. Signed-off-by: Francesco Pantano <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/b79b65973da3427eae2ac56f4568319d ❌ openstack-k8s-operators-content-provider ERROR Project github.com/openstack-k8s-operators/dataplane-operator does not have the default branch master in 9s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/5e0dfd66f2f340008bd320e04f286145 ❌ openstack-k8s-operators-content-provider ERROR Project github.com/openstack-k8s-operators/dataplane-operator does not have the default branch master in 9s |
recheck |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/c59194344a684e1ea40e656dcb7f020f ❌ openstack-k8s-operators-content-provider ERROR Project github.com/openstack-k8s-operators/dataplane-operator does not have the default branch master in 11s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified this change in my environment
@agarcia64: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, agarcia64, fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
03d8437
into
openstack-k8s-operators:dev-preview3
In the DP3 content galera is not enabled by default. This patch adds the missing boolean to make sure we don't be blocked by kubebuilder during the CR creation.