Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new curl url for docker.io in pin-bundle script #638

Merged

Conversation

viroel
Copy link
Contributor

@viroel viroel commented Jan 23, 2024

Since we are facing issues with quay.rdoproject to push image from Prow CI, we plan to move jobs images to docker.io. To properly build the bundles we need to fix pin-bundle-images script to retrieve the proper tag.

@viroel
Copy link
Contributor Author

viroel commented Jan 23, 2024

Testing here: openshift/release#47943

Since we are facing issues with quay.rdoproject to push image from
Prow CI, we plan to move jobs images to docker.io. To properly build the
bundles we need to fix pin-bundle-images script to retrieve the
proper tag.
@dprince
Copy link
Contributor

dprince commented Jan 23, 2024

@viroel looks okay to me, merge when the tests look good

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/56b6dd22e6bc4eb489bd42799eb9c2bb

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 42m 50s
podified-multinode-edpm-deployment-crc FAILURE in 22m 08s
cifmw-crc-podified-edpm-baremetal FAILURE in 17m 21s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 27m 18s

@viroel
Copy link
Contributor Author

viroel commented Jan 23, 2024

recheck

issues don' t seems to be related. We may merge anyways to unblock other PRs

@viroel
Copy link
Contributor Author

viroel commented Jan 23, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/baa104e0655c455aa5d2142422f6963c

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 00m 55s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 05s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 17m 35s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 25m 00s

@viroel
Copy link
Contributor Author

viroel commented Jan 23, 2024

/override rdoproject.org/github-check

we need this patch to fix issues in push registry

Copy link
Contributor

openshift-ci bot commented Jan 23, 2024

@viroel: Overrode contexts on behalf of viroel: rdoproject.org/github-check

In response to this:

/override rdoproject.org/github-check

we need this patch to fix issues in push registry

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, viroel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b31c78a into openstack-k8s-operators:main Jan 23, 2024
7 checks passed
@viroel viroel deleted the docker_pin_hack branch January 23, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants