Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version update #631

Closed
wants to merge 2 commits into from
Closed

Version update #631

wants to merge 2 commits into from

Conversation

dprince
Copy link
Contributor

@dprince dprince commented Jan 16, 2024

No description provided.

@dprince dprince marked this pull request as draft January 16, 2024 13:57
@openshift-ci openshift-ci bot requested review from lewisdenny and stuggi January 16, 2024 13:57
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/eb09160219cf4e59b560d242afe3ee12

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 51m 27s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 08m 09s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 32m 52s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 32m 35s

gibizer
gibizer reviewed Jan 16, 2024
View reviewed changes
controllers/core/openstackversion_controller.go Outdated Show resolved Hide resolved
controllers/core/openstackversion_controller.go Outdated Show resolved Hide resolved
controllers/core/openstackversion_controller.go Outdated Show resolved Hide resolved
controllers/core/openstackversion_controller.go Outdated Show resolved Hide resolved
controllers/core/openstackversion_controller.go Show resolved Hide resolved
controllers/core/openstackversion_controller.go Outdated Show resolved Hide resolved
@dprince dprince force-pushed the version_update branch 2 times, most recently from 019900d to d38f2cc Compare January 17, 2024 16:22
@gibizer
Copy link
Contributor

gibizer commented Jan 22, 2024

Thanks for fixing my comments. What is in the PR looks good now. I will check back after it is out from Draft.

@dprince dprince closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibizer gibizer gibizer left review comments

@lewisdenny lewisdenny Awaiting requested review from lewisdenny

@stuggi stuggi Awaiting requested review from stuggi

Assignees
No one assigned
Labels
approved do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dprince @gibizer