-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove "mariadb" CRD references in favor of Galera #597
remove "mariadb" CRD references in favor of Galera #597
Conversation
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/bec7558db743426487de42d97ae6b624 ✔️ openstack-k8s-operators-content-provider SUCCESS in 48m 30s |
8c448f6
to
bb60bf3
Compare
recheck |
/ok-to-test |
@zzzeek also need to remove the section from PROJECT (top level file in this repo) |
I'm not seeing what's in PROJECT to remove.... |
oh OK in the mariadb-operator, I have to remove it from PROJECT there, got it. |
@zzzeek ack things. Sorry I got my PR reviews confused here! So one more thing on this one though. If you run 'make bundle' locally it will re-order things in the config/manifests/bases/openstack-operator.clusterserviceversion.yaml a bit due to the mariadb removal. Probably good to do that here as well. |
bb60bf3
to
c11f748
Compare
that's done now |
To support upstream mariadb-operator removal of the "MariaDB" resource in [1], openstack-operator should refer only to Galera as the relational database deployment [1] openstack-k8s-operators/mariadb-operator#173
c11f748
to
dec82e1
Compare
/test openstack-operator-build-deploy-kuttl |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprince, zzzeek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I noticed the "make bundle" removed entries related to ceilometer and replaced them with entries that refer to "telemetry", even though i have not made any changes in that regard. is that expected here? was there another change merged that hadn't updated "bundle" ? |
guess prow was grumpy last night looks like it made it this time |
cbcaeae
into
openstack-k8s-operators:main
To support upstream mariadb-operator removal of the "MariaDB" resource in [1], openstack-operator should refer only to Galera as the relational database deployment
[1] openstack-k8s-operators/mariadb-operator#173