Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "mariadb" CRD references in favor of Galera #597

Merged

Conversation

zzzeek
Copy link
Contributor

@zzzeek zzzeek commented Dec 11, 2023

To support upstream mariadb-operator removal of the "MariaDB" resource in [1], openstack-operator should refer only to Galera as the relational database deployment

[1] openstack-k8s-operators/mariadb-operator#173

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/bec7558db743426487de42d97ae6b624

✔️ openstack-k8s-operators-content-provider SUCCESS in 48m 30s
podified-multinode-edpm-deployment-crc FAILURE in 32m 49s
cifmw-crc-podified-edpm-baremetal FAILURE in 27m 45s
openstack-operator-tempest-multinode NODE_FAILURE Node request 099-0006738909 failed in 0s

@zzzeek
Copy link
Contributor Author

zzzeek commented Dec 11, 2023

recheck

@zzzeek
Copy link
Contributor Author

zzzeek commented Dec 11, 2023

/ok-to-test

@zzzeek zzzeek marked this pull request as ready for review December 11, 2023 22:40
@dprince
Copy link
Contributor

dprince commented Dec 13, 2023

@zzzeek also need to remove the section from PROJECT (top level file in this repo)

@zzzeek
Copy link
Contributor Author

zzzeek commented Dec 13, 2023

@zzzeek also need to remove the section from PROJECT (top level file in this repo)

I'm not seeing what's in PROJECT to remove....

@zzzeek
Copy link
Contributor Author

zzzeek commented Dec 13, 2023

@zzzeek also need to remove the section from PROJECT (top level file in this repo)

I'm not seeing what's in PROJECT to remove....

oh OK in the mariadb-operator, I have to remove it from PROJECT there, got it.

@dprince
Copy link
Contributor

dprince commented Dec 13, 2023

@zzzeek ack things. Sorry I got my PR reviews confused here! So one more thing on this one though. If you run 'make bundle' locally it will re-order things in the config/manifests/bases/openstack-operator.clusterserviceversion.yaml a bit due to the mariadb removal. Probably good to do that here as well.

@zzzeek
Copy link
Contributor Author

zzzeek commented Dec 13, 2023

@zzzeek ack things. Sorry I got my PR reviews confused here! So one more thing on this one though. If you run 'make bundle' locally it will re-order things in the config/manifests/bases/openstack-operator.clusterserviceversion.yaml a bit due to the mariadb removal. Probably good to do that here as well.

that's done now

To support upstream mariadb-operator removal of the "MariaDB"
resource in [1], openstack-operator should refer only to Galera
as the relational database deployment

[1] openstack-k8s-operators/mariadb-operator#173
@dprince
Copy link
Contributor

dprince commented Dec 14, 2023

/test openstack-operator-build-deploy-kuttl

Copy link
Contributor

openshift-ci bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, zzzeek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zzzeek
Copy link
Contributor Author

zzzeek commented Dec 14, 2023

I noticed the "make bundle" removed entries related to ceilometer and replaced them with entries that refer to "telemetry", even though i have not made any changes in that regard. is that expected here? was there another change merged that hadn't updated "bundle" ?

@zzzeek
Copy link
Contributor Author

zzzeek commented Dec 14, 2023

guess prow was grumpy last night looks like it made it this time

@openshift-merge-bot openshift-merge-bot bot merged commit cbcaeae into openstack-k8s-operators:main Dec 14, 2023
7 checks passed
@zzzeek zzzeek deleted the remove_mariadb branch January 25, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants