Add list of glanceAPI support #587

fmount · 2023-12-05T15:58:15Z

This change aligns the openstack-operator with the work done in the glance-operator to support the deployment of a list of glanceAPI. The logic has been improved to make sure the new CRD is supported.

Demo: https://asciinema.org/a/626515

Deploy an arbitrary number of glanceAPI glance-operator#384

Depends-On: openstack-k8s-operators/data-plane-adoption#221

softwarefactory-project-zuul · 2023-12-05T16:07:02Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5e6ff11ce6464b5fb403a07ce3d2acf0

❌ openstack-k8s-operators-content-provider FAILURE in 7m 22s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

softwarefactory-project-zuul · 2023-12-05T16:17:25Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/76c314a2714e4a919af4a8a52ee9b602

❌ openstack-k8s-operators-content-provider FAILURE in 7m 33s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

softwarefactory-project-zuul · 2023-12-05T16:27:49Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9cee41d1dd7b4c41a878096b4ed97ef2

❌ openstack-k8s-operators-content-provider FAILURE in 7m 54s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

softwarefactory-project-zuul · 2023-12-05T22:04:09Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/110e2b22d3d444de9ec34eaae4079504

❌ openstack-k8s-operators-content-provider FAILURE in 12m 50s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

softwarefactory-project-zuul · 2023-12-06T23:06:47Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d07b9f8a1e074941a3009804003615cf

❌ openstack-k8s-operators-content-provider FAILURE in 12m 36s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

softwarefactory-project-zuul · 2023-12-07T21:27:10Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/856bd9e131c14f30832cdfe3c26e5c1a

❌ openstack-k8s-operators-content-provider FAILURE in 14m 37s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

apis/core/v1beta1/openstackcontrolplane_types.go

softwarefactory-project-zuul · 2023-12-08T21:14:37Z

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/openstack-operator for 587,cd369dcb44ccefa891f008503955c7913774ac1a

softwarefactory-project-zuul · 2023-12-08T21:34:27Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/34149648dec34e138839109316954455

❌ openstack-k8s-operators-content-provider FAILURE in 12m 36s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

softwarefactory-project-zuul · 2023-12-08T22:35:58Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/adb45c9302cb41e2a2d08e349883ad9b

❌ openstack-k8s-operators-content-provider FAILURE in 14m 59s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

fmount · 2023-12-08T23:03:22Z

/retest-required

fmount · 2023-12-09T08:01:09Z

/retest-required

softwarefactory-project-zuul · 2023-12-09T09:40:19Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/0250fad4d13e4fe6be223a2d0d6d0139

❌ openstack-k8s-operators-content-provider FAILURE in 13m 12s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

softwarefactory-project-zuul · 2023-12-09T22:04:11Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e9d7a9298a744a43b9c57b8da04845bf

❌ openstack-k8s-operators-content-provider FAILURE in 12m 09s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

fmount · 2023-12-13T12:24:40Z

recheck

softwarefactory-project-zuul · 2023-12-13T14:36:35Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ff5716edd4bb4258a91788330b27f16e

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 09m 34s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 55s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 4m 05s
❌ cifmw-data-plane-adoption-OSP-17-to-extracted-crc FAILURE in 1h 49m 31s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 27m 14s

softwarefactory-project-zuul · 2023-12-13T16:28:08Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/87f81c936ea94371aa8446e1bb8e54e2

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 46m 04s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 24m 51s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 48m 11s
❌ cifmw-data-plane-adoption-OSP-17-to-extracted-crc NODE_FAILURE Node request 099-0006745051 failed in 0s
❌ openstack-operator-tempest-multinode NODE_FAILURE Node request 099-0006745052 failed in 0s

fmount · 2023-12-14T09:57:14Z

@abays I think that once this patch is rebased on its dependency (openstack-k8s-operators/glance-operator#384), we can try to update the Depends-on for zuul to openstack-k8s-operators/data-plane-adoption#221 and see if the adoption job works as expected. Even though the other jobs are failing, the Glance deployment looks good, so I'll recheck this patch once the Glance one merges.

fmount · 2023-12-14T12:13:42Z

recheck

danpawlik · 2023-12-14T13:52:49Z

recheck

softwarefactory-project-zuul · 2023-12-14T16:03:07Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/344a891610d4499486ab920ce41b8e7b

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 08m 43s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 13m 42s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 17m 14s
❌ cifmw-data-plane-adoption-OSP-17-to-extracted-crc FAILURE in 1h 42m 30s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 26m 42s

config/samples/core_v1beta1_openstackcontrolplane_galera_network_isolation.yaml

config/samples/core_v1beta1_openstackcontrolplane_network_isolation.yaml

config/samples/core_v1beta1_openstackcontrolplane_network_isolation_ceph.yaml

softwarefactory-project-zuul · 2023-12-14T19:14:28Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5971e57780624a58a677e7e3c1c15036

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 56s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 4s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 4s
❌ cifmw-data-plane-adoption-OSP-17-to-extracted-crc RETRY_LIMIT in 4s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 32m 55s

We recently introduced the ability to deploy a list of glanceAPI in the OpenStackControlPlane. This feature is not required in the adoption context, but it's critical to adapt the Glance deployment to the new api. It might be relevant in the future as long as DCN environments will be adopted. Depends-On: openstack-k8s-operators/glance-operator#384 Depends-On: openstack-k8s-operators/openstack-operator#587 Signed-off-by: Francesco Pantano <[email protected]>

fmount · 2023-12-14T21:46:31Z

recheck

softwarefactory-project-zuul · 2023-12-14T23:46:46Z

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ac5ef3afdd254c11875cb2ea327e1be6

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 59m 01s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 07m 18s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 16m 39s
❌ cifmw-data-plane-adoption-OSP-17-to-extracted-crc FAILURE in 1h 37m 26s
❌ openstack-operator-tempest-multinode FAILURE in 41m 12s

fmount · 2023-12-15T08:36:35Z

After rechecking zuul we can see that:

Data Plane Adoption failure is expected, because it requires [1];
Tempest multinode fails, but looks like we've lost OCP in that job, even the must-gather is not able to retrieve any log
Both baremetal and crc-net-isolation jobs work as expected, and for example we can see the right CR being created [2]

@abays not sure you have extra comments on this one, but once I have the green light I'll start merging the glance dependency so we can focus to get this one in.

[1] openstack-k8s-operators/data-plane-adoption#221
[2] https://logserver.rdoproject.org/87/587/1a38ed3932845b92e816339a56bfe15a4cba856d/github-check/cifmw-crc-podified-edpm-baremetal/22e8e91/ci-framework-data/logs/quay-io-openstack-k8s-operators-openstack-must-gather-sha256-c5501ac502209eda400116b0511a5cf07f0537f650b706f63006628472a846af/namespaces/openstack/crs/openstackcontrolplanes.core.openstack.org/openstack-galera-network-isolation.yaml

fmount · 2023-12-15T09:25:52Z

recheck

This change aligns the openstack-operator with the work done in the glance-operator to support the deployment of an arbitrary number of glanceAPI(s). The logic has been improved to support the new CRD and the Glance reconcile logic has been revisited as well. Signed-off-by: Francesco Pantano <[email protected]>

abays

/lgtm

openshift-ci · 2023-12-15T15:09:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [abays]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the do-not-merge/work-in-progress label Dec 5, 2023

openshift-ci bot requested review from abays and frenzyfriday December 5, 2023 15:58

fmount force-pushed the list_of_glanceapi branch from f90343e to 90ed9d9 Compare December 5, 2023 16:08

fmount mentioned this pull request Dec 5, 2023

Deploy an arbitrary number of glanceAPI openstack-k8s-operators/glance-operator#384

Merged

fmount force-pushed the list_of_glanceapi branch from 90ed9d9 to 19d1321 Compare December 5, 2023 16:18

fmount force-pushed the list_of_glanceapi branch from 19d1321 to 5ca75b5 Compare December 5, 2023 21:50

fmount force-pushed the list_of_glanceapi branch from 5ca75b5 to 5eb5c99 Compare December 6, 2023 22:51

fmount force-pushed the list_of_glanceapi branch from 5eb5c99 to cf6fab8 Compare December 7, 2023 21:11

abays reviewed Dec 8, 2023

View reviewed changes

apis/core/v1beta1/openstackcontrolplane_types.go Show resolved Hide resolved

fmount force-pushed the list_of_glanceapi branch from cf6fab8 to cd369dc Compare December 8, 2023 21:14

openshift-merge-robot added the needs-rebase label Dec 8, 2023

fmount force-pushed the list_of_glanceapi branch from cd369dc to b7b3c45 Compare December 8, 2023 21:20

openshift-merge-robot removed the needs-rebase label Dec 8, 2023

fmount force-pushed the list_of_glanceapi branch from b7b3c45 to a01e9f7 Compare December 8, 2023 22:19

fmount force-pushed the list_of_glanceapi branch from a01e9f7 to e993bf6 Compare December 9, 2023 09:25

fmount force-pushed the list_of_glanceapi branch from e993bf6 to 0a5b349 Compare December 9, 2023 21:51

fmount changed the title ~~WIP - Add list of glanceAPI support~~ Add list of glanceAPI support Dec 13, 2023

openshift-ci bot removed the do-not-merge/work-in-progress label Dec 13, 2023

fmount force-pushed the list_of_glanceapi branch from e711412 to cea42b3 Compare December 13, 2023 14:40

abays reviewed Dec 14, 2023

View reviewed changes

config/samples/core_v1beta1_openstackcontrolplane_galera_network_isolation.yaml Outdated Show resolved Hide resolved

abays reviewed Dec 14, 2023

View reviewed changes

config/samples/core_v1beta1_openstackcontrolplane_network_isolation.yaml Outdated Show resolved Hide resolved

abays reviewed Dec 14, 2023

View reviewed changes

config/samples/core_v1beta1_openstackcontrolplane_network_isolation_ceph.yaml Outdated Show resolved Hide resolved

fmount force-pushed the list_of_glanceapi branch from cea42b3 to 1a38ed3 Compare December 14, 2023 17:19

fmount force-pushed the list_of_glanceapi branch from 1a38ed3 to 5818366 Compare December 15, 2023 12:32

fmount force-pushed the list_of_glanceapi branch from 5818366 to f36c6c4 Compare December 15, 2023 12:44

abays approved these changes Dec 15, 2023

View reviewed changes

openshift-ci bot assigned abays Dec 15, 2023

openshift-ci bot added the lgtm label Dec 15, 2023

openshift-ci bot added the approved label Dec 15, 2023

openshift-merge-bot bot merged commit aa63bf3 into openstack-k8s-operators:main Dec 15, 2023
7 checks passed

fmount mentioned this pull request Dec 15, 2023

[standalone]Fix default VM resources openstack-k8s-operators/install_yamls#666

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add list of glanceAPI support #587

Add list of glanceAPI support #587

fmount commented Dec 5, 2023 •

edited

Loading

softwarefactory-project-zuul bot commented Dec 5, 2023

softwarefactory-project-zuul bot commented Dec 5, 2023

softwarefactory-project-zuul bot commented Dec 5, 2023

softwarefactory-project-zuul bot commented Dec 5, 2023

softwarefactory-project-zuul bot commented Dec 6, 2023

softwarefactory-project-zuul bot commented Dec 7, 2023

softwarefactory-project-zuul bot commented Dec 8, 2023

softwarefactory-project-zuul bot commented Dec 8, 2023

softwarefactory-project-zuul bot commented Dec 8, 2023

fmount commented Dec 8, 2023

fmount commented Dec 9, 2023

softwarefactory-project-zuul bot commented Dec 9, 2023

softwarefactory-project-zuul bot commented Dec 9, 2023

fmount commented Dec 13, 2023

softwarefactory-project-zuul bot commented Dec 13, 2023

softwarefactory-project-zuul bot commented Dec 13, 2023

fmount commented Dec 14, 2023

fmount commented Dec 14, 2023

danpawlik commented Dec 14, 2023

softwarefactory-project-zuul bot commented Dec 14, 2023

softwarefactory-project-zuul bot commented Dec 14, 2023

fmount commented Dec 14, 2023

softwarefactory-project-zuul bot commented Dec 14, 2023

fmount commented Dec 15, 2023

fmount commented Dec 15, 2023

abays left a comment

openshift-ci bot commented Dec 15, 2023

Add list of glanceAPI support #587

Add list of glanceAPI support #587

Conversation

fmount commented Dec 5, 2023 • edited Loading

softwarefactory-project-zuul bot commented Dec 5, 2023

softwarefactory-project-zuul bot commented Dec 5, 2023

softwarefactory-project-zuul bot commented Dec 5, 2023

softwarefactory-project-zuul bot commented Dec 5, 2023

softwarefactory-project-zuul bot commented Dec 6, 2023

softwarefactory-project-zuul bot commented Dec 7, 2023

softwarefactory-project-zuul bot commented Dec 8, 2023

softwarefactory-project-zuul bot commented Dec 8, 2023

softwarefactory-project-zuul bot commented Dec 8, 2023

fmount commented Dec 8, 2023

fmount commented Dec 9, 2023

softwarefactory-project-zuul bot commented Dec 9, 2023

softwarefactory-project-zuul bot commented Dec 9, 2023

fmount commented Dec 13, 2023

softwarefactory-project-zuul bot commented Dec 13, 2023

softwarefactory-project-zuul bot commented Dec 13, 2023

fmount commented Dec 14, 2023

fmount commented Dec 14, 2023

danpawlik commented Dec 14, 2023

softwarefactory-project-zuul bot commented Dec 14, 2023

softwarefactory-project-zuul bot commented Dec 14, 2023

fmount commented Dec 14, 2023

softwarefactory-project-zuul bot commented Dec 14, 2023

fmount commented Dec 15, 2023

fmount commented Dec 15, 2023

abays left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Dec 15, 2023

fmount commented Dec 5, 2023 •

edited

Loading