New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new glanceAPI struct #514

Merged

openshift-merge-bot merged 1 commit into openstack-k8s-operators:main from fmount:single_instance

Nov 16, 2023

Contributor

fmount commented Oct 13, 2023 •

edited

Loading

This change is the first of a series where the purpose is to move away from the harcoded internal/external GlanceAPI instance in favor of an arbitrary number of GlanceAPI deployments.
The current change is based on [1] that does not introduce the ability to deploy >1 GlanceAPI instances, but introduces the a single glanceAPI struct that will serve this purpose.
The split behavior is still preserved, but it happens behind the scenes in Glance.
Finally, this patch bumps the operators to make sure everything works with the latest version of the API.

[1] openstack-k8s-operators/glance-operator#329

openshift-ci bot requested review from olliewalsh and stuggi

October 13, 2023 11:29

fmount requested review from fultonj, stuggi, dprince and abays and removed request for olliewalsh and stuggi

October 13, 2023 11:29

fmount added the do-not-merge/hold label

softwarefactory-project-zuul bot commented Oct 13, 2023

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/807f1254ae9a41d58cd62b4816bf83c3

❌ openstack-k8s-operators-content-provider FAILURE in 11m 14s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

fmount force-pushed the single_instance branch from 8b604ac to 1371b7b Compare

October 13, 2023 13:44

softwarefactory-project-zuul bot commented Oct 13, 2023

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/f30943d530ff4dea91bbf0d0f74f9dec

❌ openstack-k8s-operators-content-provider FAILURE in 10m 48s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

fmount force-pushed the single_instance branch from 1371b7b to 970454c Compare

October 13, 2023 16:34

softwarefactory-project-zuul bot commented Oct 13, 2023

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/04fcdbb60f574ddab726a0b496b3be91

❌ openstack-k8s-operators-content-provider FAILURE in 10m 38s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

fmount force-pushed the single_instance branch 2 times, most recently from 5c5303c to 0c51edb Compare

October 13, 2023 20:11

softwarefactory-project-zuul bot commented Oct 13, 2023

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/3824f47b3f814cb0ac24e82ac1c1f62f

❌ openstack-k8s-operators-content-provider FAILURE in 10m 15s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

fmount force-pushed the single_instance branch 2 times, most recently from 199baae to dcf5980 Compare

October 16, 2023 07:04

softwarefactory-project-zuul bot commented Oct 16, 2023

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/04b4e2c19eb840648f1d61516801f96c

❌ openstack-k8s-operators-content-provider FAILURE in 10m 21s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

fmount force-pushed the single_instance branch from dcf5980 to 6dec99e Compare

October 16, 2023 11:37

softwarefactory-project-zuul bot commented Oct 16, 2023

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/697e44b1cba74ba68e0dbf6254e20724

❌ openstack-k8s-operators-content-provider FAILURE in 9m 31s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

fmount force-pushed the single_instance branch from 6dec99e to 2085538 Compare

October 16, 2023 20:36

softwarefactory-project-zuul bot commented Oct 16, 2023

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/052be63c5e7e4348a314d5e574e5462d

❌ openstack-k8s-operators-content-provider FAILURE in 10m 19s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

fmount force-pushed the single_instance branch from 2085538 to a4125bc Compare

October 17, 2023 08:20

softwarefactory-project-zuul bot commented Oct 17, 2023

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/c950ccc87ccf4eadacf2a1a16b9d2367

❌ openstack-k8s-operators-content-provider FAILURE in 9m 49s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

fmount mentioned this pull request

Increase kuttl test default timeout #518

Merged

fmount force-pushed the single_instance branch 2 times, most recently from 8e6d27a to 051479c Compare

October 17, 2023 10:33

softwarefactory-project-zuul bot commented Oct 17, 2023

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/53ac8a2eb869410da39ece8e81f9e650

❌ openstack-k8s-operators-content-provider FAILURE in 10m 08s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

fmount force-pushed the single_instance branch 2 times, most recently from a1ff1ae to 2d22685 Compare

November 8, 2023 06:21

softwarefactory-project-zuul bot commented Nov 8, 2023

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/de785b585d2c4b379d0b7f796e19cab2

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 27m 32s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 01m 12s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 00m 35s
❌ openstack-operator-tempest-multinode FAILURE in 1h 10m 32s

openshift-merge-robot added the needs-rebase label

fao89 pushed a commit to fmount/data-plane-adoption that referenced this pull request


          Move glance to the new API definition

GlanceAPI has been simplified by patches [1][2], and the implication of
those patches is a change in the CRD used to define the glanceAPI
service.
This patch aligns both the existing documentation and the test suite to
work with the new way of deploying glance.

[1] openstack-k8s-operators/glance-operator#329
[2] openstack-k8s-operators/openstack-operator#514

Signed-off-by: Francesco Pantano <[email protected]>

fmount force-pushed the single_instance branch from 2d22685 to 806461f Compare

November 15, 2023 09:01

openshift-merge-robot removed the needs-rebase label

fmount force-pushed the single_instance branch from 806461f to 90bae2e Compare

November 15, 2023 09:04

softwarefactory-project-zuul bot commented Nov 15, 2023

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/e6c25b8efed34b7e91d67ac9412acaed

❌ openstack-k8s-operators-content-provider FAILURE in 10m 50s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

fmount force-pushed the single_instance branch 2 times, most recently from eb03c4a to ed4b2b1 Compare

November 15, 2023 09:22

softwarefactory-project-zuul bot commented Nov 15, 2023

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/364f1396a581447d954b379d2e80787f

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 26m 57s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 03m 21s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 03m 55s
❌ openstack-operator-tempest-multinode FAILURE in 1h 09m 11s

Contributor Author

fmount commented Nov 15, 2023

recheck

softwarefactory-project-zuul bot commented Nov 15, 2023

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/eadc4628c15f40c7bbece99d4cd3392c

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 25m 17s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 05m 01s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 59m 07s
❌ openstack-operator-tempest-multinode FAILURE in 1h 10m 11s


          Add new glanceAPI struct

d204b96

This change is the first of a series where the purpose is to move away
from the harcoded internal/external glanceAPI instance in favor of an
arbitrary number of GlanceAPI instances.
The current change doesn't introduce the ability to deploy >1 GlanceAPI
instance, but introduces the logic that will serve this purpose.
The split behavior is still preserved, but it happens behind the scenes
in Glance.

Signed-off-by: Francesco Pantano <[email protected]>

fmount force-pushed the single_instance branch from ed4b2b1 to d204b96 Compare

November 15, 2023 13:32

Akrog mentioned this pull request

Update openstack-k8s-operators (main) #543

Merged

1 task

fmount commented

View reviewed changes

config/samples/core_v1beta1_openstackcontrolplane.yaml

                     databaseInstance: openstack
                     storageClass: ""
                     storageRequest: 10G
+                    glanceAPI:
+                      type: single

Contributor Author

fmount Nov 15, 2023 •

edited

Loading

@abays given we're using statefulset where each instance has stable access to a given pvc, we need to have a "single" instance when "file" is used as a backend (same story for all the backends except Ceph)

fmount removed the do-not-merge/hold label

fmount added a commit to fmount/architecture that referenced this pull request


          Mova VA1 to the new GlanceAPI definition

858e117

Glance moved to a new API definition via [1][2] and this patch aligns
VA1 to the current changes.

[1] openstack-k8s-operators/glance-operator#329
[2] openstack-k8s-operators/openstack-operator#514

Signed-off-by: Francesco Pantano <[email protected]>

fmount mentioned this pull request

Move VA1 to the new GlanceAPI definition openstack-k8s-operators/architecture#32

Merged

fmount added a commit to fmount/architecture that referenced this pull request


          Move VA1 to the new GlanceAPI definition

ba4a2e6

Glance moved to a new API definition via [1][2] and this patch aligns
VA1 to the current changes.

[1] openstack-k8s-operators/glance-operator#329
[2] openstack-k8s-operators/openstack-operator#514

Signed-off-by: Francesco Pantano <[email protected]>

abays approved these changes

View reviewed changes

Contributor

abays left a comment

/lgtm

openshift-ci bot assigned abays

openshift-ci bot added the lgtm label

Contributor

openshift-ci bot commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [abays]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the approved label

openshift-merge-bot bot merged commit 927d8b1 into openstack-k8s-operators:main

1 check passed

fmount added a commit to fmount/data-plane-adoption that referenced this pull request


          Move glance to the new API definition

1bc22ff

GlanceAPI has been simplified by patches [1][2], and the implication of
those patches is a change in the CRD used to define the glanceAPI
service.
This patch aligns both the existing documentation and the test suite to
work with the new way of deploying glance.

[1] openstack-k8s-operators/glance-operator#329
[2] openstack-k8s-operators/openstack-operator#514

Signed-off-by: Francesco Pantano <[email protected]>

bogdando pushed a commit to bogdando/data-plane-adoption that referenced this pull request


          Move glance to the new API definition

35e7b0f

GlanceAPI has been simplified by patches [1][2], and the implication of
those patches is a change in the CRD used to define the glanceAPI
service.
This patch aligns both the existing documentation and the test suite to
work with the new way of deploying glance.

[1] openstack-k8s-operators/glance-operator#329
[2] openstack-k8s-operators/openstack-operator#514

Signed-off-by: Francesco Pantano <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels