Drop redhat service from default nodeset samples #1229
Conversation
The service requires rhel nodes to run which we don't have upstream and so is not being tested. Also enabling this service requires additional vars like activationkey,token, username etc. Also it broke some downstream jobs which running older version of operators and using these upstream samples. Related-Issue: OSPCIX-596
|
/test openstack-operator-build-deploy-kuttl |
|
it shouldn't break older versions, as the redhat service isn't on older samples: https://github.com/openstack-k8s-operators/openstack-operator/blob/18.0.0-proposed/config/samples/dataplane_v1beta1_openstackdataplanenodeset.yaml#L10-L25 |
Yes that is one of the reason to remove it from default samples. it can be handled downstream by using different branches. But removing it from default is due to other reasons in commit message (just adding the service is not sufficient as require other vars to be configured and it's not being tested upstream) , additionally it will also fix the downstream jobs. |
|
/test openstack-operator-build-deploy-kuttl |
|
/test openstack-operator-build-deploy-kuttl |
|
/test openstack-operator-build-deploy-kuttl |
|
/test openstack-operator-build-deploy-kuttl |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karelyatin, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 6d3e5c2
into
openstack-k8s-operators:main
The service requires rhel nodes to run which we
don't have upstream and so is not being tested.
Also enabling this service requires additional
vars like activationkey,token, username etc.
Also it broke some downstream jobs which running
older version of operators and using these upstream samples.
Related-Issue: OSPCIX-596