Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openstack-k8s-operators (main) #1204

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

openstack-k8s-ci-robot
Copy link
Contributor

@openstack-k8s-ci-robot openstack-k8s-ci-robot commented Nov 23, 2024

This PR contains the following updates:

Package Type Update Change
github.com/openstack-k8s-operators/barbican-operator/api require digest 37d5a9b -> 42e8034
github.com/openstack-k8s-operators/cinder-operator/api require digest 9e97663 -> 9941c12
github.com/openstack-k8s-operators/designate-operator/api require digest c06a12f -> 7bc56aa
github.com/openstack-k8s-operators/glance-operator/api require digest 89e9fe9 -> d8e6e13
github.com/openstack-k8s-operators/heat-operator/api require digest 1c476cf -> 1491a54
github.com/openstack-k8s-operators/horizon-operator/api require digest c38568c -> f5fcda7
github.com/openstack-k8s-operators/infra-operator/apis require digest b225194 -> 18e54a0
github.com/openstack-k8s-operators/ironic-operator/api require digest 63d25e2 -> 3faa669
github.com/openstack-k8s-operators/keystone-operator/api require digest 322aab6 -> dc78e72
github.com/openstack-k8s-operators/lib-common/modules/certmanager require digest 6dc9fd0 -> d172b3a
github.com/openstack-k8s-operators/lib-common/modules/common require digest 6dc9fd0 -> d172b3a
github.com/openstack-k8s-operators/lib-common/modules/openstack indirect digest 6dc9fd0 -> d172b3a
github.com/openstack-k8s-operators/lib-common/modules/storage require digest 6dc9fd0 -> d172b3a
github.com/openstack-k8s-operators/lib-common/modules/test require digest 6dc9fd0 -> d172b3a
github.com/openstack-k8s-operators/manila-operator/api require digest bfd56f1 -> 110a2db
github.com/openstack-k8s-operators/mariadb-operator/api require digest c6bef3c -> 4e7d8f7
github.com/openstack-k8s-operators/neutron-operator/api require digest 591a3bc -> 6be30e8
github.com/openstack-k8s-operators/nova-operator/api require digest 42b7b84 -> afc9663
github.com/openstack-k8s-operators/octavia-operator/api require digest bc64ab6 -> ceff33a
github.com/openstack-k8s-operators/openstack-baremetal-operator/api require digest 3d33d3d -> 6f26588
github.com/openstack-k8s-operators/ovn-operator/api require digest a34ad51 -> 5d6fb2e
github.com/openstack-k8s-operators/placement-operator/api require digest e4c1ba6 -> 92a44b2
github.com/openstack-k8s-operators/swift-operator/api require digest 6ab57de -> 477944c
github.com/openstack-k8s-operators/telemetry-operator/api require digest f2c8dd9 -> ff87fed
github.com/openstack-k8s-operators/test-operator/api require digest 20927e1 -> b2b1b46

Configuration

📅 Schedule: Branch creation - "every weekend" in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@openshift-ci openshift-ci bot requested review from olliewalsh and rebtoor November 23, 2024 05:33
@stuggi
Copy link
Contributor

stuggi commented Nov 25, 2024

/retest

@stuggi
Copy link
Contributor

stuggi commented Nov 26, 2024

/retest

@openstack-k8s-ci-robot openstack-k8s-ci-robot changed the title Update github.com/openstack-k8s-operators/infra-operator/apis digest to 6821e16 (main) Update openstack-k8s-operators (main) Nov 30, 2024
@openstack-k8s-ci-robot openstack-k8s-ci-robot force-pushed the renovate/main-openstack-k8s-operators branch from 2f16820 to 9b93397 Compare November 30, 2024 05:37
@openshift-ci openshift-ci bot removed the lgtm label Nov 30, 2024
@openstack-k8s-ci-robot openstack-k8s-ci-robot force-pushed the renovate/main-openstack-k8s-operators branch 2 times, most recently from 1f09c9d to 1bc846c Compare December 7, 2024 07:59
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 10, 2024
@openstack-k8s-ci-robot openstack-k8s-ci-robot force-pushed the renovate/main-openstack-k8s-operators branch from 1bc846c to 880c5c3 Compare December 10, 2024 07:40
@openshift-ci openshift-ci bot removed the lgtm label Dec 10, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6d6fec81733e4f6a8c2e39f48e7a3c53

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 08m 46s
podified-multinode-edpm-deployment-crc POST_FAILURE in 1h 16m 01s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 32m 21s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 2h 56m 54s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 39m 54s

@stuggi
Copy link
Contributor

stuggi commented Dec 10, 2024

recheck

@stuggi
Copy link
Contributor

stuggi commented Dec 10, 2024

/test openstack-operator-build-deploy-kuttl

@hjensas
Copy link
Contributor

hjensas commented Dec 11, 2024

/test precommit-check
/test openstack-operator-build-deploy-kuttl

@openstack-k8s-ci-robot openstack-k8s-ci-robot force-pushed the renovate/main-openstack-k8s-operators branch from 880c5c3 to e7ae6ca Compare December 12, 2024 14:50
@openstack-k8s-ci-robot
Copy link
Contributor Author

openstack-k8s-ci-robot commented Dec 13, 2024

ℹ Artifact update notice

File name: apis/go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 11 additional dependencies were updated

Details:

Package Change
k8s.io/api v0.29.11 -> v0.29.12
k8s.io/apimachinery v0.29.11 -> v0.29.12
k8s.io/client-go v0.29.11 -> v0.29.12
github.com/emicklei/go-restful/v3 v3.11.2 -> v3.12.0
github.com/go-openapi/jsonpointer v0.20.2 -> v0.21.0
github.com/go-openapi/jsonreference v0.20.4 -> v0.21.0
github.com/go-openapi/swag v0.22.9 -> v0.23.0
github.com/prometheus/procfs v0.12.0 -> v0.13.0
k8s.io/apiextensions-apiserver v0.29.11 -> v0.29.12
k8s.io/component-base v0.29.11 -> v0.29.12
k8s.io/kube-openapi v0.0.0-20240228011516-70dd3763d340 -> v0.0.0-20240322212309-b815d8309940
File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 11 additional dependencies were updated

Details:

Package Change
k8s.io/api v0.29.11 -> v0.29.12
k8s.io/apimachinery v0.29.11 -> v0.29.12
k8s.io/client-go v0.29.11 -> v0.29.12
github.com/emicklei/go-restful/v3 v3.11.2 -> v3.12.0
github.com/go-openapi/jsonpointer v0.20.2 -> v0.21.0
github.com/go-openapi/jsonreference v0.20.4 -> v0.21.0
github.com/go-openapi/swag v0.22.9 -> v0.23.0
github.com/prometheus/procfs v0.12.0 -> v0.13.0
k8s.io/apiextensions-apiserver v0.29.11 -> v0.29.12
k8s.io/component-base v0.29.11 -> v0.29.12
k8s.io/kube-openapi v0.0.0-20240228011516-70dd3763d340 -> v0.0.0-20240322212309-b815d8309940

@openstack-k8s-ci-robot openstack-k8s-ci-robot force-pushed the renovate/main-openstack-k8s-operators branch from e7ae6ca to a556240 Compare December 13, 2024 12:11
@stuggi
Copy link
Contributor

stuggi commented Dec 13, 2024

@vakwetu are the barbican changes ok to be merged? afaik pkcs11 is optional, so it should be fine?

ERROR: "NoBools": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.barbican.template.pkcs11.AESGCMGenerateIV may not be a boolean
ERROR: "NoBools": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.barbican.template.pkcs11.OSLockingOK may not be a boolean
ERROR: "NoBools": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.barbican.template.pkcs11.keyWrapGenerateIV may not be a boolean
ERROR: "NoBools": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.barbican.template.pkcs11.alwaysSetCKASensitive may not be a boolean
ERROR: "NoNewRequiredFields": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.barbican.template.pkcs11.HMACLabel is new and may not be required
ERROR: "NoNewRequiredFields": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.barbican.template.pkcs11.MKEKLabel is new and may not be required
ERROR: "NoNewRequiredFields": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.barbican.template.pkcs11.libraryPath is new and may not be required
ERROR: "NoNewRequiredFields": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.barbican.template.pkcs11.loginSecret is new and may not be required
ERROR: "NoNewRequiredFields": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.barbican.template.pkcs11.serverAddress is new and may not be required
ERROR: "NoNewRequiredFields": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.barbican.template.pkcs11.type is new and may not be required

@omersch381 @beagles same for designate?

ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.designate.template.designateCentral.redisHostIPs must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.designate.template.designateProducer.redisHostIPs must set x-kubernetes-list-type
ERROR: "NoNewRequiredFields": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.designate.template.redisServiceName is new and may not be required

@stuggi
Copy link
Contributor

stuggi commented Dec 13, 2024

/test openstack-operator-build-deploy-kuttl

@openstack-k8s-ci-robot openstack-k8s-ci-robot force-pushed the renovate/main-openstack-k8s-operators branch from a556240 to ed2a81f Compare December 14, 2024 05:13
@stuggi
Copy link
Contributor

stuggi commented Dec 16, 2024

@vakwetu are the barbican changes ok to be merged? afaik pkcs11 is optional, so it should be fine?

ERROR: "NoBools": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.barbican.template.pkcs11.AESGCMGenerateIV may not be a boolean
ERROR: "NoBools": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.barbican.template.pkcs11.OSLockingOK may not be a boolean
ERROR: "NoBools": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.barbican.template.pkcs11.keyWrapGenerateIV may not be a boolean
ERROR: "NoBools": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.barbican.template.pkcs11.alwaysSetCKASensitive may not be a boolean
ERROR: "NoNewRequiredFields": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.barbican.template.pkcs11.HMACLabel is new and may not be required
ERROR: "NoNewRequiredFields": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.barbican.template.pkcs11.MKEKLabel is new and may not be required
ERROR: "NoNewRequiredFields": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.barbican.template.pkcs11.libraryPath is new and may not be required
ERROR: "NoNewRequiredFields": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.barbican.template.pkcs11.loginSecret is new and may not be required
ERROR: "NoNewRequiredFields": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.barbican.template.pkcs11.serverAddress is new and may not be required
ERROR: "NoNewRequiredFields": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.barbican.template.pkcs11.type is new and may not be required

@omersch381 @beagles same for designate?

ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.designate.template.designateCentral.redisHostIPs must set x-kubernetes-list-type
ERROR: "ListsMustHaveSSATags": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.designate.template.designateProducer.redisHostIPs must set x-kubernetes-list-type
ERROR: "NoNewRequiredFields": crd/openstackcontrolplanes.core.openstack.org version/v1beta1 field/^.spec.designate.template.redisServiceName is new and may not be required

designate now has a required RedisServiceName which is required with a default, which seems to be odd https://github.com/openstack-k8s-operators/designate-operator/blob/main/api/v1beta1/designate_types.go#L185

@openstack-k8s-ci-robot openstack-k8s-ci-robot force-pushed the renovate/main-openstack-k8s-operators branch from ed2a81f to c080dc8 Compare December 16, 2024 13:11
@vakwetu
Copy link
Contributor

vakwetu commented Dec 16, 2024

@stuggi yes - the barbican changes are definitely OK to be merged. I made a comment about them in the initial commit. The pkcs11 struct is new and is optional. Its also referenced as a pointer - which will be nil for a barbican undergoing update.

@stuggi
Copy link
Contributor

stuggi commented Dec 16, 2024

  [FAILED] Timed out after 10.000s.
  The function passed to Eventually failed at /go/pkg/mod/github.com/openstack-k8s-operators/lib-common/modules/[email protected]/test/helpers/conditions.go:46 with:
  Does not have condition type MinorUpdateDataplane
  Expected
      <bool>: false
  to be true
  In [It] at: /go/pkg/mod/github.com/openstack-k8s-operators/lib-common/modules/[email protected]/test/helpers/conditions.go:53 @ 12/16/24 13:24:26.777
  Full Stack Trace
    github.com/openstack-k8s-operators/lib-common/modules/common/test/helpers.(*TestHelper).ExpectCondition(0xc0018e4e10, {{0xc001998ff0, 0x24}, {0xc001b0c090, 0x19}}, {0x25670e0?, 0x2331cf0}, {0x21fe518, 0x14}, {0x21dd1f4, ...})
    	/go/pkg/mod/github.com/openstack-k8s-operators/lib-common/modules/[email protected]/test/helpers/conditions.go:53 +0x38e
    github.com/openstack-k8s-operators/openstack-operator/tests/functional/ctlplane_test.glob..func4.3.2.6({0x258fb40, 0xc0010d23f0})
    	/go/src/github.com/openstack-k8s-operators/operator/tests/functional/ctlplane/openstackversion_controller_test.go:538 +0x1cc
    reflect.Value.call({0x1d8d000?, 0xc002fc86c0?, 0x3b9aca00?}, {0x21dd23c, 0x4}, {0xc0021ac378, 0x1, 0x3b?})
    	/usr/lib/golang/src/reflect/value.go:596 +0xce7
    reflect.Value.Call({0x1d8d000?, 0xc002fc86c0?, 0xc000074500?}, {0xc0021ac378?, 0xc76181cbbc28?, 0x20c8fc0?})
    	/usr/lib/golang/src/reflect/value.go:380 +0xb9
    github.com/onsi/gomega/internal.(*AsyncAssertion).buildActualPoller.func3()
    	/go/pkg/mod/github.com/onsi/[email protected]/internal/async_assertion.go:325 +0x11f
    github.com/onsi/gomega/internal.(*AsyncAssertion).match(0xc000374000, {0x2576f20?, 0x380c360}, 0x1, {0x0, 0x0, 0x0})
    	/go/pkg/mod/github.com/onsi/[email protected]/internal/async_assertion.go:398 +0x179
    github.com/onsi/gomega/internal.(*AsyncAssertion).Should(0xc000374000, {0x2576f20, 0x380c360}, {0x0, 0x0, 0x0})
    	/go/pkg/mod/github.com/onsi/[email protected]/internal/async_assertion.go:145 +0x86
    github.com/openstack-k8s-operators/openstack-operator/tests/functional/ctlplane_test.glob..func4.3.2()
    	/go/src/github.com/openstack-k8s-operators/operator/tests/functional/ctlplane/openstackversion_controller_test.go:553 +0x755

with openstack-k8s-operators/lib-common#590 , the MinorUpdateDataplane condition is gone as soon the update is done. @dprince do you see an issue with this, or it is ok to just remove the check for the condition in https://github.com/openstack-k8s-operators/openstack-operator/blob/main/tests/functional/ctlplane/openstackversion_controller_test.go#L538-L543 ?

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/03e431000b074cbe9830ab8201705454

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 23m 17s
podified-multinode-edpm-deployment-crc POST_FAILURE in 1h 21m 56s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 38m 10s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 06m 19s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 48m 44s

@dprince
Copy link
Contributor

dprince commented Dec 16, 2024

with openstack-k8s-operators/lib-common#590 , the MinorUpdateDataplane condition is gone as soon the update is done. @dprince do you see an issue with this, or it is ok to just remove the check for the condition in https://github.com/openstack-k8s-operators/openstack-operator/blob/main/tests/functional/ctlplane/openstackversion_controller_test.go#L538-L543 ?

Lets just drop that condition I think. No need to have it if there is no realistic way you would need it anymore.

When the dataplane minor update finished, the controller will not
set a OpenStackVersionMinorUpdateOVNDataplane after [1]. This
change will remove the no longer required check.

[1] openstack-k8s-operators/lib-common#590

Signed-off-by: Martin Schuppert <[email protected]>
@stuggi
Copy link
Contributor

stuggi commented Dec 17, 2024

/test openstack-operator-build-deploy-kuttl

@openstack-k8s-ci-robot
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@stuggi
Copy link
Contributor

stuggi commented Dec 17, 2024

Get "https://api.oko-12.oooci.ccitredhat.com:6443/api?timeout=32s": dial tcp 38.102.83.63:6443: connect: no route to host

@stuggi
Copy link
Contributor

stuggi commented Dec 17, 2024

/test openstack-operator-build-deploy-kuttl

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bd1a1fb3eeaa4fe2ade9b0ea3a567f99

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 01m 23s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 01s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 33m 15s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 40m 53s
openstack-operator-tempest-multinode FAILURE in 1h 48m 29s

@stuggi
Copy link
Contributor

stuggi commented Dec 17, 2024

recheck

@stuggi
Copy link
Contributor

stuggi commented Dec 17, 2024

/override ci/prow/precommit-check

1 similar comment
@stuggi
Copy link
Contributor

stuggi commented Dec 17, 2024

/override ci/prow/precommit-check

Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

@stuggi: Overrode contexts on behalf of stuggi: ci/prow/precommit-check

In response to this:

/override ci/prow/precommit-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 17, 2024
Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openstack-k8s-ci-robot, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi
Copy link
Contributor

stuggi commented Dec 17, 2024

/retest

@stuggi
Copy link
Contributor

stuggi commented Dec 17, 2024

/override ci/prow/precommit-check

Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

@stuggi: Overrode contexts on behalf of stuggi: ci/prow/precommit-check

In response to this:

/override ci/prow/precommit-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 7456bee into main Dec 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants