test crd schema checker

.pre-commit-config.yaml

@@ -25,6 +25,13 @@ repos:
       entry: make
       args: ['operator-lint']
       pass_filenames: false
+    - id: make-crd-schema-check
+      name: make-crd-schema-check
+      language: system
+      entry: make
+      args: ['crd-schema-check']
+      pass_filenames: false
+      verbose: true
 
 - repo: https://github.com/pre-commit/pre-commit-hooks
   rev: v4.4.0

Makefile

@@ -477,3 +477,10 @@ run-with-webhook: manifests generate fmt vet ## Run a controller from your host.
 .PHONY: webhook-cleanup
 webhook-cleanup:
 	/bin/bash hack/clean_local_webhook.sh
+
+CRD_SCHEMA_CHECKER_VERSION ?= release-4.16
+
+PHONY: crd-schema-check
+crd-schema-check: manifests
+	INSTALL_DIR=$(LOCALBIN) CRD_SCHEMA_CHECKER_VERSION=$(CRD_SCHEMA_CHECKER_VERSION) hack/build-crd-schema-checker.sh
+	INSTALL_DIR=$(LOCALBIN) BASE_REF="$${PULL_BASE_SHA:-$(BRANCH)}" hack/crd-schema-checker.sh

apis/bases/core.openstack.org_openstackcontrolplanes.yaml

@@ -10879,6 +10879,8 @@ spec:
                           format: int32
                           minimum: 0
                           type: integer
+                        foo:
+                          type: integer
                         nodeSelector:
                           additionalProperties:
                             type: string
@@ -14696,6 +14698,8 @@ spec:
                                 type: string
                             type: object
                           type: array
+                      required:
+                      - foo
                       type: object
                     type: object
                 type: object

apis/core/v1beta1/openstackcontrolplane_types.go

@@ -511,6 +511,9 @@ type RabbitmqTemplate struct {
 	// +operator-sdk:csv:customresourcedefinitions:type=spec
 	// NodeSelector to target subset of worker nodes running this service
 	NodeSelector *map[string]string `json:"nodeSelector,omitempty"`
+
+	// +kubebuilder:validation:Required
+	Foo int `json:"foo"`
 }
 
 // OvnSection defines the desired state of OVN services

config/crd/bases/core.openstack.org_openstackcontrolplanes.yaml

@@ -10879,6 +10879,8 @@ spec:
                           format: int32
                           minimum: 0
                           type: integer
+                        foo:
+                          type: integer
                         nodeSelector:
                           additionalProperties:
                             type: string
@@ -14696,6 +14698,8 @@ spec:
                                 type: string
                             type: object
                           type: array
+                      required:
+                      - foo
                       type: object
                     type: object
                 type: object

hack/build-crd-schema-checker.sh

@@ -0,0 +1,15 @@
+#!/bin/bash
+set -euxo pipefail
+
+if [ -f "$INSTALL_DIR/crd-schema-checker" ]; then
+    exit 0
+fi
+
+mkdir -p "$INSTALL_DIR/git-tmp"
+git clone https://github.com/openshift/crd-schema-checker.git \
+    -b "$CRD_SCHEMA_CHECKER_VERSION" "$INSTALL_DIR/git-tmp"
+pushd "$INSTALL_DIR/git-tmp"
+GOWORK=off make
+cp crd-schema-checker "$INSTALL_DIR/"
+popd
+rm -rf "$INSTALL_DIR/git-tmp"

hack/crd-schema-checker.sh

@@ -0,0 +1,21 @@
+#!/bin/bash
+set -euxo pipefail
+
+CHECKER=$INSTALL_DIR/crd-schema-checker
+
+TMP_DIR=$(mktemp -d)
+
+function cleanup {
+    rm -rf "$TMP_DIR"
+}
+
+trap cleanup EXIT
+
+
+for crd in config/crd/bases/*.yaml; do
+    mkdir -p "$(dirname "$TMP_DIR/$crd")"
+    git show "$BASE_REF:$crd" > "$TMP_DIR/$crd"
+    $CHECKER check-manifests \
+        --existing-crd-filename="$TMP_DIR/$crd" \
+        --new-crd-filename="$crd"
+done