Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor update: unblock if dataplane never deployed #1128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dprince
Copy link
Contributor

@dprince dprince commented Oct 11, 2024

Add a unit test and adjust logic to allow minor updates to complete when only the ControlPlane is completely deployed. Previously if the dataplaneDeployments were in a state of failure (upon initial deployment) a minor update would not succeed. The new logic allows targetVersiont to be switched without following the minor update workflow sequence and immediately updates the images on the Controlplane.

This is a rare case but a user actually hit it when updating the operators with failed/incomplete dataplane resources.

Jira: OSPRH-10645

Add a unit test and adjust logic to allow minor updates to
complete when only the ControlPlane is completely deployed.
Previously if the dataplaneDeployments were in a state of
failure (upon initial deployment) a minor update would not
succeed. The new logic allows targetVersiont to be switched
without following the minor update workflow sequence and
immediately updates the images on the Controlplane.

This is a rare case but a user actually hit it when
updating the operators with failed/incomplete dataplane resources.

Jira: OSPRH-10645
@openshift-ci openshift-ci bot requested review from rebtoor and slagle October 11, 2024 01:33
@dprince
Copy link
Contributor Author

dprince commented Oct 11, 2024

/test openstack-operator-build-deploy-kuttl

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprince, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprince
Copy link
Contributor Author

dprince commented Oct 21, 2024

test failure here looks valid although they weren't happening before. Will have to take a look

@stuggi
Copy link
Contributor

stuggi commented Dec 16, 2024

/retest

Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

@dprince: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/openstack-operator-build-deploy-kuttl e8a983c link true /test openstack-operator-build-deploy-kuttl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants