Merge pull request #833 from abays/fix_osv_func_test

Fix race condition in OpenStackVersion func test
openstack-k8s-operators · Jun 7, 2024 · 2c395ab · 2c395ab
2 parents 3b8e72b + 49ea221
commit 2c395ab
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/tests/functional/base_test.go b/tests/functional/base_test.go
@@ -254,10 +254,13 @@ func OpenStackVersionConditionGetter(name types.NamespacedName) condition.Condit
 	return instance.Status.Conditions
 }
 
-func OpenStackVersionRemoveFinalizer(ctx context.Context, name types.NamespacedName) error {
-	instance := GetOpenStackVersion(name)
-	instance.SetFinalizers([]string{})
-	return th.K8sClient.Update(ctx, instance)
+func OpenStackVersionRemoveFinalizer(ctx context.Context, name types.NamespacedName) {
+	Eventually(func(g Gomega) {
+		instance := GetOpenStackVersion(name)
+		instance.SetFinalizers([]string{})
+		g.Expect(th.K8sClient.Update(ctx, instance)).Should(Succeed())
+
+	}, timeout, interval).Should(Succeed())
 }
 
 func CreateOpenStackControlPlane(name types.NamespacedName, spec map[string]interface{}) client.Object {