Skip to content

Commit

Permalink
Fix nova-novncproxy route endpoint type
Browse files Browse the repository at this point in the history
since there should be a route created for the novncproxy, the
endpoint into EnsureRoute() needs to be of type public, not internal.
  • Loading branch information
stuggi committed Sep 25, 2023
1 parent 168cbd1 commit 0c8330e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions pkg/openstack/nova.go
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ func ReconcileNova(ctx context.Context, instance *corev1beta1.OpenStackControlPl
nova,
svcs,
map[service.Endpoint]service.RoutedOverrideSpec{
service.EndpointInternal: *cellTemplate.NoVNCProxyServiceTemplate.Override.Service,
service.EndpointPublic: *cellTemplate.NoVNCProxyServiceTemplate.Override.Service,
},
instance.Spec.Nova.CellOverride[cellName].NoVNCProxy.Route,
corev1beta1.OpenStackControlPlaneExposeNovaReadyCondition,
Expand All @@ -165,7 +165,7 @@ func ReconcileNova(ctx context.Context, instance *corev1beta1.OpenStackControlPl
return ctrlResult, nil
}

cellTemplate.NoVNCProxyServiceTemplate.Override.Service = ptr.To(routedOverrideSpec[service.EndpointInternal])
cellTemplate.NoVNCProxyServiceTemplate.Override.Service = ptr.To(routedOverrideSpec[service.EndpointPublic])

instance.Spec.Nova.Template.CellTemplates[cellName] = cellTemplate

Expand Down

0 comments on commit 0c8330e

Please sign in to comment.