Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module github.com/go-logr/logr to v1.4.1 #96

Closed
wants to merge 1 commit into from

Conversation

openstack-k8s-ci-robot
Copy link

@openstack-k8s-ci-robot openstack-k8s-ci-robot commented Oct 28, 2023

This PR contains the following updates:

Package Type Update Change
github.com/go-logr/logr require minor v1.2.4 -> v1.4.1

Release Notes

go-logr/logr (github.com/go-logr/logr)

v1.4.1

Compare Source

What's Changed

Full Changelog: go-logr/logr@v1.4.0...v1.4.1

v1.4.0

Compare Source

This release dramatically improves interoperability with Go's log/slog package. In particular, logr.NewContext and logr.NewContextWithSlogLogger use the same context key, which allows logr.FromContext and logr.FromContextAsSlogLogger to return logr.Logger or *slog.Logger respectively, including transparently converting each to the other as needed.

Functions logr/slogr.NewLogr and logr/slogr.ToSlogHandler have been superceded by logr.FromSlogHandler and logr.ToSlogHandler respectively, and type logr/slogr.SlogSink has been superceded by logr.SlogSink. All of the old names in logr/slogr remain, for compatibility.

Package logr/funcr now supports logr.SlogSink, meaning that it's output passes all but one of the Slog conformance tests (that exception being that funcr handles the timestamp itself).

Users who have a logr.Logger and need a *slog.Logger can call slog.New(logr.ToSlogHandler(...)) and all output will go through the same stack.

Users who have a *slog.Logger or slog.Handler can call logr.FromSlogHandler(...) and all output will go through the same stack.

What's Changed

New Contributors

Full Changelog: go-logr/logr@v1.3.0...v1.4.0

v1.3.0

Compare Source

This release adds support for slog in a new, self-contained logr/slogr package. Implementers of a logr.LogSink are encouraged, but not required, to extend their implementation to improve the quality of log output coming from a slog API call.

Breaking change: the call depth for LogSink.Enabled when called via Logger.Enabled was fixed to be the same as for other call paths. Implementers of a LogSink who have worked around this bug will need to remove their workarounds.

Security best practices were improved. Only Go versions >= 1.18 are supported by this release.

What's Changed


New Contributors

Full Changelog: go-logr/logr@v1.2.4...v1.3.0


Configuration

📅 Schedule: Branch creation - "every weekend" in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@openshift-ci openshift-ci bot requested review from hjensas and rabi October 28, 2023 04:46
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openstack-k8s-ci-robot
Once this PR has been reviewed and has the lgtm label, please assign rabi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/491954a2c6844bdfbfdc66b41458f8dd

openstack-baremetal-operator-content-provider FAILURE in 7m 57s
⚠️ openstack-baremetal-operator-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-baremetal-operator-content-provider

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/68dec5a0562e4a52b33310272ba59ea3

openstack-baremetal-operator-content-provider FAILURE in 14m 33s
⚠️ openstack-baremetal-operator-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-baremetal-operator-content-provider

@openstack-k8s-ci-robot openstack-k8s-ci-robot changed the title Update module github.com/go-logr/logr to v1.3.0 Update module github.com/go-logr/logr to v1.4.1 Dec 23, 2023
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b2ee7cf064c54122bf62f26696c58b8b

✔️ openstack-baremetal-operator-content-provider SUCCESS in 1h 19m 34s
openstack-baremetal-operator-crc-podified-edpm-baremetal FAILURE in 22m 38s

@openstack-k8s-ci-robot
Copy link
Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (v1.4.1). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@openstack-k8s-ci-robot openstack-k8s-ci-robot deleted the renovate/misc branch February 12, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants