Add IPv6 support for networkdata #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjensas
added a commit
to hjensas/dataplane-operator
that referenced
this pull request
Feb 15, 2024
Get the ipPrefix from the Cidr in the ipSet reservation, combine address and prefix when setting CtlPlaneIP in the instanceSpec. Depends-On: openstack-k8s-operators/openstack-baremetal-operator#129
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/4766cf092b9647389fe1539c20477fc6 ✔️ openstack-baremetal-operator-content-provider SUCCESS in 1h 11m 36s |
rabi
reviewed
Feb 16, 2024
Update the networkdata te Change CtlPlaneIP to use a CIDR format (ip_addr/prefix). Add a temporary compatibility layer utlizing a.b.c.d + CtlplaneNetmask to internally create the CIDR formated address. In the future we can drop CtlplaneNetmask from OpenStackBaremetalSetSpec.
hjensas
force-pushed
the
ipv6-network-data-template
branch
from
2ebade1 to
67d36f8
Compare
hjensas
added a commit
to hjensas/dataplane-operator
that referenced
this pull request
Feb 16, 2024
Get the ipPrefix from the Cidr in the ipSet reservation, combine address and prefix when setting CtlPlaneIP in the instanceSpec. Depends-On: openstack-k8s-operators/openstack-baremetal-operator#129
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hjensas, rabi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 5918cf3
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the networkdata te
Change CtlPlaneIP to use a CIDR format (ip_addr/prefix).
Add a temporary compatibility layer utlizing a.b.c.d + CtlplaneNetmask to internally create the CIDR formated address.
In the future we can drop CtlplaneNetmask from OpenStackBaremetalSetSpec.