This change ensures the baremetal-operator is built with FIPS compliance #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed the build image to ubi9/go-toolkit - Changed the base image to ubi9/minimal - Added the default GO_BUILD_EXTRA_ARGS="-tags strictfipsruntime" - Added the GO_BUILD_EXTRA_ENV_ARGS build argument to allow custom build arguments at build time. It defaults to "CGO_ENABLED=1 GO111MODULE=on" - Those default parameters have been added to enable FIPS compliance - Fixed indentation in Dockerfile - Removed TARGETOS and TARGETARCH env vars. - Added DOCKER_BUILD_ARGS variable in Makefile to pass custom parameters during podman build - Added export FAIL_FIPS_CHECK=true in .prow_ci.env file Closes: https://issues.redhat.com/browse/OSPRH-3375 Signed-off-by: Roberto Alfieri <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, rebtoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Not sure if this is a hiccup or not: ...but trying again to check /test openstack-baremetal-operator-build-deploy |
openshift-merge-bot
bot
merged commit 9d2c03c
into
openstack-k8s-operators:main
7 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ubi9/go-toolkitubi9/minimalGO_BUILD_EXTRA_ARGS="-tags strictfipsruntime"GO_BUILD_EXTRA_ENV_ARGSbuild argument to allow custom build arguments at build time. It defaults to"CGO_ENABLED=1 GO111MODULE=on"TARGETOSandTARGETARCHenv vars.DOCKER_BUILD_ARGSvariable in Makefile to pass custom parameters during podman buildFAIL_FIPS_CHECK=truein.prow_ci.envfile to enable FIPS tests on prowCloses: https://issues.redhat.com/browse/OSPRH-3375