Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update operator-sdk to use local/bin #112

Merged

Conversation

yazug
Copy link
Contributor

@yazug yazug commented Dec 13, 2023

specify version for operator-sdk for make bundle
download operator-sdk pinned version when generating bundle update make bundle to use local operator-sdk

@openshift-ci openshift-ci bot requested review from abays and viroel December 13, 2023 17:07
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/2f3be61e5cc643d6859ecf31a29bffcf

✔️ openstack-baremetal-operator-content-provider SUCCESS in 22m 20s
openstack-baremetal-operator-crc-podified-edpm-baremetal NODE_FAILURE Node request 099-0006745397 failed in 0s

@yazug
Copy link
Contributor Author

yazug commented Dec 14, 2023

/test openstack-baremetal-operator-build-deploy

@yazug yazug force-pushed the standardize_makefile branch from 686da2d to 2eb1a1b Compare December 19, 2023 17:40
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/0d25aba600b34515aecf1b0ec79020d9

openstack-baremetal-operator-content-provider FAILURE in 10m 35s
⚠️ openstack-baremetal-operator-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-baremetal-operator-content-provider

Makefile Outdated Show resolved Hide resolved
update operator-sdk to use local/bin
specify version for operator-sdk for make bundle
download operator-sdk pinned version when generating bundle
update make bundle to use local operator-sdk
bump operator-sdk to 1.31 to match ci-operator.yaml
sync with skeleton from operator-sdk
moved ginko down to later in Makefile
moved Build Directives to match skeleton

Signed-off-by: Jon Schlueter <[email protected]>
@yazug yazug force-pushed the standardize_makefile branch from 2eb1a1b to d4e36f5 Compare December 19, 2023 18:26
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, yazug

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/816f8d7f021c43fc82861bd55221c35a

✔️ openstack-baremetal-operator-content-provider SUCCESS in 1h 40m 34s
openstack-baremetal-operator-crc-podified-edpm-baremetal FAILURE in 1h 20m 38s

@abays
Copy link
Contributor

abays commented Dec 20, 2023

recheck

@openshift-merge-bot openshift-merge-bot bot merged commit 5403c76 into openstack-k8s-operators:main Dec 20, 2023
8 checks passed
@yazug yazug deleted the standardize_makefile branch January 2, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants