Merge pull request #231 from rabi/node_selector

Expose ProvisionServerNodeSelector in baremetalset spec
openstack-k8s-operators · Nov 18, 2024 · a1d460a · a1d460a
2 parents a50471a + 400f623
commit a1d460a
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 5 deletions.
diff --git a/api/bases/baremetal.openstack.org_openstackbaremetalsets.yaml b/api/bases/baremetal.openstack.org_openstackbaremetalsets.yaml
@@ -268,9 +268,15 @@ spec:
                 type: object
                 x-kubernetes-map-type: atomic
               provisionServerName:
-                description: ProvisionServerName - Optional. If supplied will be used
-                  as the base Image for the baremetalset instead of baseImageURL.
+                description: ProvisionServerName - Optional. Existing OpenStackProvisionServer
+                  to use, else one would be created.
                 type: string
+              provisionServerNodeSelector:
+                additionalProperties:
+                  type: string
+                description: ProvisonServerNodeSelector to target subset of worker
+                  nodes running provision server
+                type: object
               provisioningInterface:
                 description: ProvisioningInterface - Optional. If not provided along
                   with ProvisionServerName, it would be discovered from CBO.  This

diff --git a/api/v1beta1/openstackbaremetalset_types.go b/api/v1beta1/openstackbaremetalset_types.go
@@ -71,9 +71,12 @@ type OpenStackBaremetalSetSpec struct {
 	// +kubebuilder:default=metadata
 	// +kubebuilder:validation:Optional
 	AutomatedCleaningMode AutomatedCleaningMode `json:"automatedCleaningMode,omitempty"`
-	// ProvisionServerName - Optional. If supplied will be used as the base Image for the baremetalset instead of baseImageURL.
+	// ProvisionServerName - Optional. Existing OpenStackProvisionServer to use, else one would be created.
 	// +kubebuilder:validation:Optional
 	ProvisionServerName string `json:"provisionServerName,omitempty"`
+	// +kubebuilder:validation:Optional
+	// ProvisonServerNodeSelector to target subset of worker nodes running provision server
+	ProvisonServerNodeSelector map[string]string `json:"provisionServerNodeSelector,omitempty"`
 	// ProvisioningInterface - Optional. If not provided along with ProvisionServerName, it would be discovered from CBO.  This is the provisioning interface on the OCP masters/workers.
 	// +kubebuilder:validation:Optional
 	ProvisioningInterface string `json:"provisioningInterface,omitempty"`

diff --git a/api/v1beta1/zz_generated.deepcopy.go b/api/v1beta1/zz_generated.deepcopy.go
diff --git a/config/crd/bases/baremetal.openstack.org_openstackbaremetalsets.yaml b/config/crd/bases/baremetal.openstack.org_openstackbaremetalsets.yaml
@@ -268,9 +268,15 @@ spec:
                 type: object
                 x-kubernetes-map-type: atomic
               provisionServerName:
-                description: ProvisionServerName - Optional. If supplied will be used
-                  as the base Image for the baremetalset instead of baseImageURL.
+                description: ProvisionServerName - Optional. Existing OpenStackProvisionServer
+                  to use, else one would be created.
                 type: string
+              provisionServerNodeSelector:
+                additionalProperties:
+                  type: string
+                description: ProvisonServerNodeSelector to target subset of worker
+                  nodes running provision server
+                type: object
               provisioningInterface:
                 description: ProvisioningInterface - Optional. If not provided along
                   with ProvisionServerName, it would be discovered from CBO.  This

diff --git a/controllers/openstackbaremetalset_controller.go b/controllers/openstackbaremetalset_controller.go
@@ -519,6 +519,7 @@ func (r *OpenStackBaremetalSetReconciler) provisionServerCreateOrUpdate(
 		provisionServer.Spec.OSContainerImageURL = instance.Spec.OSContainerImageURL
 		provisionServer.Spec.ApacheImageURL = instance.Spec.ApacheImageURL
 		provisionServer.Spec.AgentImageURL = instance.Spec.AgentImageURL
+		provisionServer.Spec.NodeSelector = instance.Spec.ProvisonServerNodeSelector
 		provisionServer.Spec.Interface = instance.Spec.ProvisioningInterface
 
 		err := controllerutil.SetControllerReference(instance, provisionServer, helper.GetScheme())