-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cifmw kuttl job as parent job for reusability #902
Use cifmw kuttl job as parent job for reusability #902
Conversation
In the depends-on PR, a new job definition is introduced that runs kuttl tests following the pattern used in nova-operator. This is done mainly to reuse the job definition for watcher-operator, which has just introduced kuttl testing following the same pattern. This change modifies the nova job to use the same parent. Depends-On: openstack-k8s-operators/ci-framework#2571
Skipping CI for Draft Pull Request. |
This change depends on a change that failed to merge. Change openstack-k8s-operators/ci-framework#2571 is needed. |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b2b13e2fb1e74c1190bfb54e6d2779c4 ✔️ openstack-meta-content-provider SUCCESS in 3h 01m 02s |
recheck |
/hold marking this as ready for review since the kuttl job is passing, but setting a hold until the cifmw PR with the parent job definition merges |
This change depends on a change that failed to merge. Change openstack-k8s-operators/ci-framework#2571 is needed. |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5e01fc0098b848f6aab0cbd932a02979 ✔️ openstack-meta-content-provider SUCCESS in 3h 50m 54s |
After the parenting change for the kuttl job, the nova-operator-base job is unused and can be removed. Similarly, the playbooks ported to the ci-framework can be removed.
check-rdo the depency is now merged so lets retests with the final version |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im happy that this is functional and that the job logging is still working as intended
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cescgina, SeanMooney The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
418bd2b
into
openstack-k8s-operators:main
In the depends-on PR, a new job definition is introduced that runs kuttl
tests following the pattern used in nova-operator. This is done mainly
to reuse the job definition for watcher-operator, which has just
introduced kuttl testing following the same pattern.
This change modifies the nova job to use the same parent.
Depends-On: openstack-k8s-operators/ci-framework#2571