Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cifmw kuttl job as parent job for reusability #902

Conversation

cescgina
Copy link
Contributor

In the depends-on PR, a new job definition is introduced that runs kuttl
tests following the pattern used in nova-operator. This is done mainly
to reuse the job definition for watcher-operator, which has just
introduced kuttl testing following the same pattern.

This change modifies the nova job to use the same parent.

Depends-On: openstack-k8s-operators/ci-framework#2571

In the depends-on PR, a new job definition is introduced that runs kuttl
tests following the pattern used in nova-operator. This is done mainly
to reuse the job definition for watcher-operator, which has just
introduced kuttl testing following the same pattern.

This change modifies the nova job to use the same parent.

Depends-On: openstack-k8s-operators/ci-framework#2571
Copy link
Contributor

openshift-ci bot commented Nov 28, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#2571 is needed.

@cescgina
Copy link
Contributor Author

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b2b13e2fb1e74c1190bfb54e6d2779c4

✔️ openstack-meta-content-provider SUCCESS in 3h 01m 02s
✔️ nova-operator-kuttl SUCCESS in 48m 06s
✔️ nova-operator-tempest-multinode SUCCESS in 2h 14m 30s
nova-operator-tempest-multinode-ceph FAILURE in 2h 11m 06s

@cescgina
Copy link
Contributor Author

recheck

@cescgina
Copy link
Contributor Author

/hold marking this as ready for review since the kuttl job is passing, but setting a hold until the cifmw PR with the parent job definition merges

Copy link

This change depends on a change that failed to merge.

Change openstack-k8s-operators/ci-framework#2571 is needed.

@cescgina
Copy link
Contributor Author

recheck

.zuul.yaml Show resolved Hide resolved
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/5e01fc0098b848f6aab0cbd932a02979

✔️ openstack-meta-content-provider SUCCESS in 3h 50m 54s
✔️ nova-operator-kuttl SUCCESS in 46m 05s
✔️ nova-operator-tempest-multinode SUCCESS in 2h 05m 03s
nova-operator-tempest-multinode-ceph FAILURE in 2h 39m 05s

After the parenting change for the kuttl job, the nova-operator-base job
is unused and can be removed. Similarly, the playbooks ported to the
ci-framework can be removed.
@SeanMooney
Copy link
Contributor

check-rdo the depency is now merged so lets retests with the final version

@cescgina
Copy link
Contributor Author

cescgina commented Dec 3, 2024

/hold cancel

Copy link
Contributor

@SeanMooney SeanMooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cescgina, SeanMooney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 418bd2b into openstack-k8s-operators:main Dec 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants