Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default heal_instance_info_cache_interval=-1 #888

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Oct 30, 2024

The supported networking backends expected to work without the periodic
healing of the cache in nova. So turning the periodic healing off can be
done to gain performance.

Resolves: OSPRH-10744

@openshift-ci openshift-ci bot requested review from lewisdenny and stuggi October 30, 2024 17:05
Copy link
Contributor

openshift-ci bot commented Oct 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gibizer
Copy link
Contributor Author

gibizer commented Oct 30, 2024

/hold

@lewisdenny lewisdenny removed their request for review October 30, 2024 23:35
@gibizer
Copy link
Contributor Author

gibizer commented Nov 4, 2024

recheck
Seems to be working OK.

@gibizer gibizer force-pushed the heal_instance_info_cache_interval-0 branch from 3559224 to 3223c19 Compare November 4, 2024 09:57
@gibizer gibizer changed the title DNM: test with heal_instance_info_cache_interval=0 DNM: test with heal_instance_info_cache_interval=-1 Nov 4, 2024
@gibizer
Copy link
Contributor Author

gibizer commented Nov 4, 2024

switched from 0 to -1 as that disables triggering the periodic task all together instead of just make it noop, so it is more clear from the logs that we are not running the task at all.

@gibizer
Copy link
Contributor Author

gibizer commented Nov 8, 2024

recheck so far so good
no heal period is visible now in the nova-compute logs.

@gibizer gibizer force-pushed the heal_instance_info_cache_interval-0 branch from 3223c19 to 5433a18 Compare November 18, 2024 15:57
@gibizer gibizer changed the title DNM: test with heal_instance_info_cache_interval=-1 Default heal_instance_info_cache_interval=-1 Nov 18, 2024
@gibizer
Copy link
Contributor Author

gibizer commented Nov 18, 2024

I need an approve both from neutron and nova folks that this is OK to go in.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8dadd72e7bbf49c981cdeaee1789f544

✔️ openstack-meta-content-provider SUCCESS in 4h 39m 12s
✔️ nova-operator-kuttl SUCCESS in 45m 51s
✔️ nova-operator-tempest-multinode SUCCESS in 2h 10m 54s
nova-operator-tempest-multinode-ceph FAILURE in 22m 41s

@gibizer
Copy link
Contributor Author

gibizer commented Nov 20, 2024

recheck unrelated

2024-11-18 14:07:12.745706 | controller |   msg: 'Failed to download metadata for repo ''delorean-component-barbican'': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried'

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c40c3a814e484a5f919ed5169ea8682b

openstack-meta-content-provider FAILURE in 13m 12s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

@gibizer
Copy link
Contributor Author

gibizer commented Nov 21, 2024

recheck content provider

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/720e17b9d70a48749c8c1fae6e1e6462

openstack-meta-content-provider FAILURE in 10m 58s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-meta-content-provider
⚠️ nova-operator-tempest-multinode-ceph SKIPPED Skipped due to failed job openstack-meta-content-provider

@gibizer
Copy link
Contributor Author

gibizer commented Nov 21, 2024

lets try a rebase as it seems to be a compile error due to a recent change on main/openstack-operator.

The supported networking backends expected to work without the periodic
healing of the cache in nova. So turning the periodic healing off can be
done to gain performance.

Resolves: OSPRH-10744
@gibizer gibizer force-pushed the heal_instance_info_cache_interval-0 branch from 5433a18 to afcbb14 Compare November 21, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant