[VNC]Cleanup configuration

[gibizer]

While reviewing other PRs we noticed that there is some unused template
parameters for the vnc configurations. So I started cleaning up it. Then
I noticed that never filled template parameters in our nova.conf related
to vnc. So this PR cleans up the [vnc] section and the related config
generation code. To be able to follow our template I split the template
to compute and vncproxy parts and made sure that only the relevant
configs are applied for each service. Also fixed a small bug that
ignored config generation errors.

[gibizer]

After #522 lands the core of this PR will not be needed as #522 already removes the internal endpoint. But there are cleanups in the PR that still needed.

Also there is extra cleanup discovered that can be done here:

I think novncproxy_host novncproxy_port and server_listen can be dropped from the template as they are unused when the config is rendered. I will do a cleanup separtely.

[gibizer]

We know that tempest will only be green again after openstack-k8s-operators/openstack-operator#457 is landed.

[gibizer]

/test nova-operator-build-deploy-tempest

[mrkisaolamb]

this can be even more simplified to :

{{if eq .service_name "nova-novncproxy"}}
[vnc]
enabled = True
novncproxy_host = "::0"
novncproxy_port = 6080
{{else if (index . "novncproxy_base_url") }}
[vnc]
enabled = True
novncproxy_base_url = {{ .novncproxy_base_url }}
server_listen = "::0"
{{/* https://docs.openstack.org/oslo.config/latest/configuration/format.html#substitution    */}}
# note we may want to use console_host instead of my_ip however it wont be resolved via
# dns currently so we need to use my_ip for now.
# https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.console_host
server_proxyclient_address = "$my_ip"
{{else}}
[vnc]
enabled = False
{{end}}

or

{{if eq .service_name "nova-novncproxy"}}
[vnc]
enabled = True
novncproxy_host = "::0"
novncproxy_port = 6080
{{else if (index . "novncproxy_base_url") }}
[vnc]
enabled = True
novncproxy_base_url = {{ .novncproxy_base_url }}
server_listen = "::0"
{{/* https://docs.openstack.org/oslo.config/latest/configuration/format.html#substitution    */}}
# note we may want to use console_host instead of my_ip however it wont be resolved via
# dns currently so we need to use my_ip for now.
# https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.console_host
server_proxyclient_address = "$my_ip"
{{else if eq .service_name "nova-compute"}}
[vnc]
enabled = False
{{end}}

In both cases we have one logic block with fewer {{end}}

[gibizer]

While it is less nesting it does not really express the same thing. We need [vnc] section for two types of services novnc and compute. And in case of a compute we either need to enable the vnc support (if we have the novncproxy_base_url) or disable it. We should not generate a [vnc] section for other services ever, not even if for some broken reason they get novncproxy_base_url template parameter.

[gibizer]

I think log term we would be better to have a split configuration template but I need to discuss at with @SeanMooney

[gibizer]

It is further complicated now that the ironic virt driver support landed

[gibizer]

I think I managed to flatten it during the rebase

[mrkisaolamb]

lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gibizer, mrKisaoLamb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [gibizer,mrKisaoLamb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/717ac83266f44020a431248f8fa43e55

❌ nova-operator-content-provider FAILURE in 12m 12s
⚠️ nova-operator-kuttl SKIPPED Skipped due to failed job nova-operator-content-provider

[gibizer]

I think the dataplane-operator version in openstack-operator is so old that we lost the bundle image for that commit from quay.io. :/

[gibizer]

/retest
recreated the missing dataplane-opertor bundle

[gibizer]

recheck

[openshift-ci]

@gibizer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/nova-operator-build-deploy-tempest	863615c	link	false	/test nova-operator-build-deploy-tempest

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.