Skip to content

Commit

Permalink
Fix VNC config generation
Browse files Browse the repository at this point in the history
863615c reworked the VNC config
template but made a mistake that causes that the vncproxy service gets
two [vnc] section generated and non vnc related services gets a
[vnc]enabled=false generated.

This is fixed now.
  • Loading branch information
gibizer authored and openshift-merge-robot committed Sep 29, 2023
1 parent 111dbd1 commit 95349c9
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions templates/nova.conf
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,7 @@ notify_on_state_change = vm_and_task_state
enabled = True
novncproxy_host = "::0"
novncproxy_port = 6080
{{end}}

{{ if and (eq .service_name "nova-compute") .vnc_enabled }}
{{ else if and (eq .service_name "nova-compute") .vnc_enabled }}
[vnc]
enabled = True
novncproxy_base_url = {{ .novncproxy_base_url }}
Expand All @@ -141,7 +139,7 @@ server_listen = "::0"
# dns currently so we need to use my_ip for now.
# https://docs.openstack.org/nova/latest/configuration/config.html#DEFAULT.console_host
server_proxyclient_address = "$my_ip"
{{else}}
{{else if and (eq .service_name "nova-compute") (not .vnc_enabled) }}
[vnc]
enabled = False
{{end}}
Expand Down

0 comments on commit 95349c9

Please sign in to comment.