Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump CONTROLLER_TOOLS_VERSION to 0.14.0 #373

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Bump CONTROLLER_TOOLS_VERSION to 0.14.0 #373

merged 1 commit into from
Dec 9, 2024
+17 −25

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Dec 9, 2024

bump controller tools to the version which bumps k8s deps to v0.29.0, which aligns with the version in the operators.

@openshift-ci openshift-ci bot requested review from gouthampacha and viroel December 9, 2024 07:37
@openshift-ci openshift-ci bot added the approved label Dec 9, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8f77e5f6a8c6454c9fef1facf7a544fd

❌ openstack-k8s-operators-content-provider FAILURE in 7m 20s
⚠️ manila-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ manila-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

@stuggi stuggi force-pushed the bump_controller_tools branch from 7884398 to d02a2e1 Compare December 9, 2024 08:33
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e5c653e2867648e5bd2582268f6aa6d6

❌ openstack-k8s-operators-content-provider FAILURE in 9m 35s
⚠️ manila-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)
⚠️ manila-operator-tempest SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider (non-voting)

@stuggi
Bump CONTROLLER_TOOLS_VERSION to 0.14.0
67f6b1b 
bump controller tools to the version which bumps k8s deps to
v0.29.0, which aligns with the version in the operators.

Signed-off-by: Martin Schuppert <[email protected]>
@stuggi stuggi force-pushed the bump_controller_tools branch from d02a2e1 to 67f6b1b Compare December 9, 2024 10:00
@fmount fmount self-requested a review December 9, 2024 13:48
fmount
fmount approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmount, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 084339f into openstack-k8s-operators:main Dec 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmount fmount fmount approved these changes

@gouthampacha gouthampacha Awaiting requested review from gouthampacha

@viroel viroel Awaiting requested review from viroel

Assignees

@fmount fmount

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuggi @fmount