Add ensureNAD common function #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest-required |
fmount
force-pushed
the
nad
branch
2 times, most recently
from
182a0f8 to
dd89c8b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This patch improves the work started with verifyServiceSecret and introduces an ensureNAD function that is common to all the Manila controllers. In addition, the compound form is extended to all the verifyServiceSecret function calls. Signed-off-by: Francesco Pantano <[email protected]>
|
/lgtm Thanks for this refactoring @fmount |
openshift-merge-bot
bot
merged commit 1fc2563
into
openstack-k8s-operators:main
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves the work started with
verifyServiceSecretand introduces anensureNADfunction that is common to all theManilacontrollers. In addition, the compound form is extended to all theverifyServiceSecretfunction calls.