Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the probe healthcheck script ipv6 compatible #304

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Make the probe healthcheck script ipv6 compatible #304

merged 1 commit into from
Jul 22, 2024

Conversation

gouthampacha
Copy link
Contributor

@gouthampacha gouthampacha commented Jul 22, 2024 •
edited by openshift-ci bot
Loading

The heartbeat server uses IPv4 addresses by default; fix it.

Jira: OSPRH-8857

@gouthampacha @rabi
Make the probe healthcheck script ipv6 compatible
e032a8a 
Co-authored-by: Rabi Mishra <[email protected]>
Jira: OSPRH-8857
@openshift-ci openshift-ci bot requested review from dprince and olliewalsh July 22, 2024 18:01
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gouthampacha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gouthampacha
Copy link
Contributor Author

cc @rabi @silvacarloss

@silvacarloss
Copy link
Contributor

/lgtm
Fix is in line with what was implemented on Cinder. Thank you for working on this enhancements for supporting IPv6.

@openshift-ci openshift-ci bot added the lgtm label Jul 22, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 9f27b86 into openstack-k8s-operators:main Jul 22, 2024
9 checks passed
@gouthampacha gouthampacha deleted the issue/OSPRH-8857 branch July 22, 2024 21:22
@silvacarloss
Copy link
Contributor

/cherry-pick 18.0.0-proposed

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 23, 2024
Merged
@openshift-cherrypick-robot
Copy link

@silvacarloss: new pull request created: #305

In response to this:

/cherry-pick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprince dprince Awaiting requested review from dprince

@olliewalsh olliewalsh Awaiting requested review from olliewalsh

Assignees

@silvacarloss silvacarloss

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gouthampacha @silvacarloss @openshift-cherrypick-robot