-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Required Infrastructure Annotations to CSV #292
Add Required Infrastructure Annotations to CSV #292
Conversation
@@ -6,6 +6,11 @@ metadata: | |||
capabilities: Basic Install | |||
features.operators.openshift.io/disconnected: "true" | |||
features.operators.openshift.io/fips-compliant: "true" | |||
features.operators.openshift.io/proxy-aware: "false" | |||
features.operators.openshift.io/tls-profiles: "false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whether the operator implements well-known tunables to modify the TLS cipher suite used by the operator and, if applicable, any of the workloads it manages.
@gouthampacha wdyt about this (the tls-profiles
one)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok looks like the general direction is to set everything to false
and validate or move to true any relevant parameter later in time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is what I think we're recommending for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
operators.openshift.io/infrastructure-features: '["disconnected"]'
bellow is deprecated. we could remove it https://docs.openshift.com/container-platform/4.14/operators/operator_sdk/osdk-generating-csvs.html#osdk-csv-manual-annotations-deprecated_osdk-generating-csvs in a follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack thank you, and +1 to remove it in a follow up.
Implements: OSPRH-7888 Signed-off-by: Francesco Pantano <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a12dadd
into
openstack-k8s-operators:main
Implements: https://issues.redhat.com/browse/OSPRH-7919