Fix api log file increases indefinitely #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
|
I think we should update [1] to make kuttl pass. |
The manila-api pod uses a file between the manila-api service and a sidecar to pass the manila logs from the service to the stdout. With the current code it will grow forever, which makes no sense, since the stdout from the pod itself is already being stored, under /var/log/pods and/or in a centralized logging service. This patch makes the oslo.log service rotate the log file once it reaches 20MB in size. Other projects like nova and glance set the limit to 50MB and they keep 5 rotated files, but I think that keeping rotated files is useless here and 50MB seems a bit much. Unfortunately we need to at least keep 1 copy, or oslo.log will not do the right thing if set to 0. We also need to redirect errors in the sidecar container that tails the log to /dev/null to prevent tail error messages whenever the file gets rotated.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Akrog, fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit fa69b45
into
openstack-k8s-operators:main
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The manila-api pod uses a file between the manila-api service and a sidecar to pass the manila logs from the service to the stdout.
With the current code it will grow forever, which makes no sense, since the stdout from the pod itself is already being stored, under /var/log/pods and/or in a centralized logging service.
This patch makes the oslo.log service rotate the log file once it reaches 20MB in size.
Other projects like nova and glance set the limit to 50MB and they keep 5 rotated files, but I think that keeping rotated files is useless here and 50MB seems a bit much.
Unfortunately we need to at least keep 1 copy, or oslo.log will not do the right thing if set to 0.
We also need to redirect errors in the sidecar container that tails the log to /dev/null to prevent tail error messages whenever the file gets rotated.