Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move certmanager test helper into certmanager module #365

Merged
merged 2 commits into from
Oct 11, 2023
Merged

move certmanager test helper into certmanager module #365

merged 2 commits into from
Oct 11, 2023

Conversation

stuggi
Copy link
Contributor

@stuggi stuggi commented Oct 11, 2023

No description provided.

@stuggi stuggi requested a review from gibizer October 11, 2023 14:01
gibizer
gibizer reviewed Oct 11, 2023
View reviewed changes
Copy link
Contributor

@gibizer gibizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the TestHelper in modules/test is now unused so we can remove that as well.

@stuggi stuggi force-pushed the move_certmanager_test_helpers branch from 61171ca to d04ab52 Compare October 11, 2023 14:57
gibizer
gibizer approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@gibizer gibizer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stuggi

@stuggi stuggi merged commit e8a0540 into openstack-k8s-operators:main Oct 11, 2023
2 checks passed
@gibizer
Copy link
Contributor

gibizer commented Oct 11, 2023 •
edited by stuggi
Loading

We need adaption patches to the service operators (sorry I did not noticed this before):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibizer gibizer gibizer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stuggi @gibizer