Support for RabbitMQ notifications #325
Conversation
mauricioharley
force-pushed
the
add_notification
branch
from
9a497d5 to
7ae898d
Compare
mauricioharley
force-pushed
the
add_notification
branch
from
7ae898d to
eb69314
Compare
mauricioharley
force-pushed
the
add_notification
branch
from
eb69314 to
5298553
Compare
|
/test functional |
xek
force-pushed
the
add_notification
branch
from
a500543 to
3f1b206
Compare
|
It looks like the kuttl tests might need an update here? |
|
/retest |
|
/retest |
mauricioharley
force-pushed
the
add_notification
branch
from
3f1b206 to
4ed509c
Compare
| @@ -3,6 +3,7 @@ kind: KeystoneAPI | |||
| metadata: | |||
| name: keystone | |||
| spec: | |||
| containerImage: quay.io/podified-antelope-centos9/openstack-keystone:current-podified | |||
There was a problem hiding this comment.
We shouldn't add explicit containerImages in the samples, as we handle these defaults elsewhere
| keystoneApiName, | ||
| ConditionGetterFunc(KeystoneConditionGetter), | ||
| condition.MemcachedReadyCondition, | ||
| corev1.ConditionUnknown, |
There was a problem hiding this comment.
It looks like condition.MemcachedReadyCondition used to be corev1.ConditionFalse. Is there a particular reason it has been changed to corev1.ConditionUnknown?
There was a problem hiding this comment.
This is due to the order of execution. Because the setting of the condition.MemcachedReadyCondition is after KeystoneRabbitMQTransportURLReadyCondition, it never gets set, because it will exit earlier with an error
See the line where MemcachedReadyCondition is set and earlier lines here: https://github.com/openstack-k8s-operators/keystone-operator/pull/325/files/4ed509ca5748368853561e6f547235ca2bdc2701#diff-89511165055af64058394ac61e20f832806f3f325b9cb3771f723d7e6cb94c8cR709
Mauricio will add a test to execute this portion.
There was a problem hiding this comment.
Ack, thank you for the explanation
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, mauricioharley, xek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 11ef8f4
into
openstack-k8s-operators:main
Depends-on: openstack-k8s-operators/install_yamls#655