Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix httpd config for X-Forwarded-Proto Jira: <OSPRH-12377> #508

Conversation

mumesan
Copy link
Contributor

@mumesan mumesan commented Jan 3, 2025

  • Fix httpd RequestHeader setting for non-TLS deployment
  • Update comment pointing to RequestHeader directive syntax

Jira: OSPRH-12377

Copy link
Contributor

openshift-ci bot commented Jan 3, 2025

Hi @mumesan. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mumesan mumesan changed the title Fix httpd config for X-Forwarded-Proto Fix httpd config for X-Forwarded-Proto Jira: <OSPRH-12377> Jan 3, 2025
@hjensas
Copy link
Contributor

hjensas commented Jan 3, 2025

I think we also need to change this file:

{{- if $vhost.TLS }}
SetEnvIf X-Forwarded-Proto https HTTPS=1
## SSL directives
SSLEngine on
SSLCertificateFile "{{ $vhost.SSLCertificateFile }}"
SSLCertificateKeyFile "{{ $vhost.SSLCertificateKeyFile }}"
{{- end }}

@mumesan mumesan force-pushed the fix_httpd_requestheader branch from f560e33 to b503b6f Compare January 3, 2025 13:06
@mumesan mumesan force-pushed the fix_httpd_requestheader branch from b503b6f to 6b9721e Compare January 3, 2025 14:26
@hjensas
Copy link
Contributor

hjensas commented Jan 3, 2025

/ok-to-test

Copy link
Contributor

openshift-ci bot commented Jan 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hjensas, mumesan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 3, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 1570fc2 into openstack-k8s-operators:main Jan 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants