-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ironic-python-agent - CA bundle inject #506
Fix ironic-python-agent - CA bundle inject #506
Conversation
60436cd
to
aba8781
Compare
do we need this? our big ca bundle already has the internal-ca-bundle included. |
Thanks Martin! We are injecting that (or atleast we intend to) since: #491 also after looking more at the lib-common, I think this patch would actually just mount the big ca bundle again under a different name. Anyhow ... I'll go back to figuring out the root cause. |
/recheck |
Currently the pxe-init script copies the certificate bundle directly to /etc/pki/ca-trust/extracted in the initramfs. When update-ca-trust runs under chroot the contents under pki/ca-trust/extracted is overwritten. See manual page: update-ca-trust(8) "EXTRACTED CONFIGURATION" section. With this change the bundle is copied to /etc/pki/ca-trust/source/anchors directory in the initramfs instead, so that update-ca-trust will find the source and update CA certs and trusts correctly. Jira: OSPRH-12526
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/69dabee1829c403a9edce379789c5bad ✔️ noop SUCCESS in 0s |
recheck
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hjensas, steveb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test ironic-operator-build-deploy-kuttl |
faf8bd6
into
openstack-k8s-operators:main
Currently the pxe-init script copies the certificate bundle directly to
/etc/pki/ca-trust/extracted
in the initramfs. Whenupdate-ca-trust
runs under chroot the contents underpki/ca-trust/extracted
is overwritten. See manual page: update-ca-trust(8) "EXTRACTED CONFIGURATION" section.With this change the bundle is copied to
/etc/pki/ca-trust/source/anchor
s directory in the initramfs instead, so thatupdate-ca-trust
will find the source and update CA certs and trusts correctly.Jira: OSPRH-12526