Merge pull request #480 from stuggi/improve_index

Make sure to log error in findObjectsForSrc()
openstack-k8s-operators · Oct 14, 2024 · 449cdbc · 449cdbc
2 parents 3857fa5 + ba42633
commit 449cdbc
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/controllers/ironicapi_controller.go b/controllers/ironicapi_controller.go
@@ -330,7 +330,8 @@ func (r *IronicAPIReconciler) findObjectsForSrc(ctx context.Context, src client.
 		}
 		err := r.List(ctx, crList, listOps)
 		if err != nil {
-			return []reconcile.Request{}
+			l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))
+			return requests
 		}
 
 		for _, item := range crList.Items {

diff --git a/controllers/ironicconductor_controller.go b/controllers/ironicconductor_controller.go
@@ -288,7 +288,8 @@ func (r *IronicConductorReconciler) findObjectsForSrc(ctx context.Context, src c
 		}
 		err := r.List(ctx, crList, listOps)
 		if err != nil {
-			return []reconcile.Request{}
+			l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))
+			return requests
 		}
 
 		for _, item := range crList.Items {

diff --git a/controllers/ironicinspector_controller.go b/controllers/ironicinspector_controller.go
@@ -370,7 +370,8 @@ func (r *IronicInspectorReconciler) findObjectsForSrc(ctx context.Context, src c
 		}
 		err := r.List(ctx, crList, listOps)
 		if err != nil {
-			return []reconcile.Request{}
+			l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))
+			return requests
 		}
 
 		for _, item := range crList.Items {

diff --git a/controllers/ironicneutronagent_controller.go b/controllers/ironicneutronagent_controller.go
@@ -268,7 +268,8 @@ func (r *IronicNeutronAgentReconciler) findObjectsForSrc(ctx context.Context, sr
 		}
 		err := r.List(ctx, crList, listOps)
 		if err != nil {
-			return []reconcile.Request{}
+			l.Error(err, fmt.Sprintf("listing %s for field: %s - %s", crList.GroupVersionKind().Kind, field, src.GetNamespace()))
+			return requests
 		}
 
 		for _, item := range crList.Items {