IPv6 network attachements - no dual stack #689
Conversation
Makefile
Outdated
| @@ -2010,6 +2012,16 @@ ifeq ($(NETWORK_BGP), true) | |||
| netattach: export INTERFACE_BGP_1=${NNCP_BGP_1_INTERFACE} | |||
| netattach: export INTERFACE_BGP_2=${NNCP_BGP_2_INTERFACE} | |||
| endif | |||
| ifeq ($(NETWORK_ISOLATION_IPV4), true) | |||
| netattach: export IPV4_ENABLED=true | |||
| netattach: export CTLPLANE_IPV6_ADDRESS_PREFIX=${NNCP_CTLPLANE_IP_ADDRESS_PREFIX} | |||
There was a problem hiding this comment.
Should this be *_IP_* instead of *_IPV6_*?
There was a problem hiding this comment.
oh my, yes it should. Fixed.
hjensas
force-pushed
the
netatt-ipv6-no-dual-stack
branch
from
ccfa50c to
1b6332d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, hjensas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/52efca4cf5304d29a889b74780947818 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 24m 05s |
|
recheck
|
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/ab9cfb0323cd47ed97f2324a83a8c8d2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 23m 28s |
Add support for IPv6 in network attachement definitions.
This does not enable dual-stack support.
NOTE: Dual stack should be possible by utilizing `ipRanges`
in the whearabouts ipam config, but attempts to use
`ipRanges` fails with an error indicating the wherabouts
version in OCP does not have this feature.
Signed-off-by: Harald Jensås <[email protected]>
hjensas
force-pushed
the
netatt-ipv6-no-dual-stack
branch
from
1b6332d to
b747422
Compare
|
/lgtm |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/edc39c53b4804140b784bb9a8b93e0fa ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 30m 10s |
|
recheck Compute kernel panic: |
openshift-merge-bot
bot
merged commit f64f03e
into
openstack-k8s-operators:main
Add support for IPv6 in network attachement definitions. This does not enable dual-stack support.
NOTE:
Dual stack should be possible by utilizing
ipRangesin the whearabouts ipam config, but attempts to useipRangesfails with an error indicating the wherabouts version in OCP does not have this feature.See: #687 (comment)