-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace networkConfig #540
base: main
Are you sure you want to change the base?
Replace networkConfig #540
Conversation
Signed-off-by: Brendan Shephard <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bshephar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/5ec9d74ae0b349219113fa7ea414b2d8 ✔️ openstack-k8s-operators-content-provider SUCCESS in 58m 27s |
recheck |
/retest-required |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/cd5ef7ebe8f44bc7a672d0f08c3cedd5 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 15m 28s |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bshephar Can we close this PR? I don't think it's needed anymore.
As part of a wider effort to consolidate configuration around ansibleVars without unnecessary abstractions, this change moves the networkConfig template from a bespoke API abstraction via
spec.nodeTemplate.networkConfig.template
to the relevant Ansible variable:edpm_network_config_template
.