Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OLM webhooks when running 'make run-with-webhook', part 2 #376

Merged

Conversation

abays
Copy link
Contributor

@abays abays commented Oct 14, 2024

Follow-up to #372 to improve comments and further automate removal of OLM components before running the operator locally

@openshift-ci openshift-ci bot requested review from lewisdenny and stuggi October 14, 2024 11:45
Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abays abays requested review from rabi and removed request for lewisdenny October 14, 2024 11:47
@abays abays force-pushed the rm_olm_webhooks_2 branch from 35dbc4b to 8090950 Compare October 14, 2024 12:42
Copy link

@rabi rabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 14, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 981e37b into openstack-k8s-operators:main Oct 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants