Update horizon to use service override #202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stuggi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 11, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 14, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 14, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 14, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 14, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 14, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 15, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 16, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
Removes creation of routes. Those get done in the openstack-operator. Via service overrides the openstack-operator customize the services for the endpoints to the desired state specified in the ctlplane CR using externalEndpoints or the service override in the service template. Jira: OSP-26690 Depends-On: openstack-k8s-operators/lib-common#313
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 17, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
|
@stuggi: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 17, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Aug 17, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 5, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 6, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 7, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 7, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 8, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 11, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 11, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 11, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 12, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 12, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 12, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
|
closing in favor of #212 |
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 12, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 12, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 14, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 18, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 20, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 20, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 20, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 20, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 21, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 21, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 21, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 22, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Sep 25, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
stuggi
added a commit
to stuggi/openstack-operator
that referenced
this pull request
Oct 2, 2023
Creates the route for the horizon, also allows to customize the route via override. Generats the service override for the env with what is configured in the externalEndpoints, or specified in the service template override. Depends-On: openstack-k8s-operators/lib-common#313 Depends-On: openstack-k8s-operators/keystone-operator#289 Depends-On: openstack-k8s-operators/horizon-operator#202 Jira: OSP-26690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes creation of routes. Those get done in the openstack-operator. Via service overrides the openstack-operator customize the services for the endpoints to the desired state specified in the ctlplane CR using externalEndpoints or the service override in the service template.
Jira: OSP-26690
Depends-On: openstack-k8s-operators/lib-common#313