Skip to content

Commit

Permalink
Fix TLSInputReadyCondition
Browse files Browse the repository at this point in the history
When GlanceAPI's reconciler is executed, it checks for the provided Input,
including TLS related info. If we're not failing (err is not nil), but
the operation is still in progress, we should use the proper InputReady
message as Reason instead the InitMessage. This patch fixes it and fix
the condition with the proper message.

Signed-off-by: Francesco Pantano <[email protected]>
  • Loading branch information
fmount committed Apr 2, 2024
1 parent e5cff17 commit fdef709
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions controllers/glanceapi_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -664,8 +664,8 @@ func (r *GlanceAPIReconciler) reconcileNormal(ctx context.Context, instance *gla
// progress operation rather than something that failed
instance.Status.Conditions.MarkUnknown(
condition.TLSInputReadyCondition,
condition.InitReason,
condition.InputReadyInitMessage)
condition.RequestedReason,
condition.InputReadyWaitingMessage)
return ctrlResult, nil
}
if hash != "" {
Expand All @@ -689,8 +689,8 @@ func (r *GlanceAPIReconciler) reconcileNormal(ctx context.Context, instance *gla
// progress operation rather than something that failed
instance.Status.Conditions.MarkUnknown(
condition.TLSInputReadyCondition,
condition.InitReason,
condition.InputReadyInitMessage)
condition.RequestedReason,
condition.InputReadyWaitingMessage)
return ctrlResult, nil
}
configVars[tls.TLSHashName] = env.SetValue(certsHash)
Expand Down

0 comments on commit fdef709

Please sign in to comment.