Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set PrintMotd to no #838

Merged

Conversation

bshephar
Copy link
Contributor

@bshephar bshephar commented Dec 5, 2024

This change explicitly sets PrintMotd to no in the sshd_config. PrintMotd defaults to yes, and we're now using PAM to manage our motd requirements in RHEL9:

https://www.man7.org/linux/man-pages/man8/pam_motd.8.html
https://www.man7.org/linux/man-pages/man5/sshd_config.5.html

@openshift-ci openshift-ci bot requested review from stuggi and viroel December 5, 2024 00:33
@openshift-ci openshift-ci bot added the approved label Dec 5, 2024
This change explicitly sets PrintMotd to no in the sshd_config.
PrintMotd defaults to yes, and we're now using PAM to manage our motd
requirements in RHEL9:

https://www.man7.org/linux/man-pages/man8/pam_motd.8.html
https://www.man7.org/linux/man-pages/man5/sshd_config.5.html
Signed-off-by: Brendan Shephard <[email protected]>
@bshephar bshephar mentioned this pull request Dec 5, 2024
@openshift-ci openshift-ci bot added the lgtm label Dec 5, 2024
Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar, fao89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c05ecdc into openstack-k8s-operators:main Dec 5, 2024
34 checks passed
bshephar added a commit to bshephar/edpm-ansible that referenced this pull request Dec 9, 2024
This partially reverts commit e032cf2.
RHEL9 and greater will use PAM by default. We only need to ensure
PrintMotd is set to "no" to avoid duplication of the motd message.

We changed the default for PrintMotd in:
openstack-k8s-operators#838

This change ensures that we don't override the PrintMotd value and
instead we allow users to be explicit about this, otherwise, we default
to no.

Signed-off-by: Brendan Shephard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants