Update the doc content for edpm_network_config #832
Merged
+32
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcandapp
force-pushed
the
osprh_4342
branch
5 times, most recently
from
dc52248 to
d9ed822
Compare
slagle
reviewed
Dec 3, 2024
|
|
||
| .. note:: | ||
| When the `edpm_network_config_tool` is set to `'os-net-config'`, the `ctlplane_gateway_ip` and `ctlplane_ip` | ||
| variables must be set on the host. |
There was a problem hiding this comment.
True - but it will be applicable to both "tools" I guess.
Also, this param was originally part of undercloud.conf - now it is defined as part of network definition. For rhoso, still not sure if user will use same control plane for ocp/edpm nodes. Removed it to avoid confusion.
| * For the latter, prepare to running os-net-config tool in the host | ||
| It creates necessary folder/files for rendering the network template | ||
| and the NIC mapping (optional) in the host | ||
| It also checks for presence of required RPMs |
There was a problem hiding this comment.
I suggest rephrasing to:
For os-net-config, the role prepares the host by:
- creating necessary folders and files for rendering network templates and NIC mappings (optional)
- Checks for the presence of required RPMS
slagle
approved these changes
Dec 4, 2024
|
|
||
| .. note:: | ||
| When the `edpm_network_config_tool` is set to `'os-net-config'`, the `ctlplane_gateway_ip` and `ctlplane_ip` | ||
| variables must be set on the host. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slagle, vcandapp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit ef239bb
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.