Escalate privs for NetworkManager-ovs install #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@leducflorian: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
slagle
approved these changes
Nov 15, 2024
When installing packages, we need to escalate privileges. This change adds become: true to the block that is installing NetworkManager-ovs for use with nmstate. Signed-off-by: Brendan Shephard <[email protected]>
bshephar
force-pushed
the
NetworkManager-ovs-become
branch
from
f13cbb8 to
2dfcf7f
Compare
fao89
approved these changes
Nov 18, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, fao89, leducflorian, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit e197c75
into
openstack-k8s-operators:main
35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing packages, we need to escalate privileges. This change adds become: true to the block that is installing NetworkManager-ovs for use with nmstate.
Jira: https://issues.redhat.com/browse/OSPRH-11663