Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BGP] Fix TLS options for local OVN DB creation #807

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

eduolivares
Copy link
Contributor

@eduolivares eduolivares commented Nov 12, 2024

The options added to the ovn-ctl commands used to create local OVN NB and SB DBs when TLS was enabled were wrong.
With this PR, the correct options are used instead.

Jira: OSPRH-11428

Copy link
Contributor

@cubeek cubeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@olliewalsh olliewalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cubeek, eduolivares, olliewalsh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Nov 15, 2024

New changes are detected. LGTM label has been removed.

@danpawlik
Copy link

recheck

1 similar comment
@danpawlik
Copy link

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2cdcdcc894ca4838810d3ff75f081947

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 56m 12s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 11s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 22m 53s
✔️ edpm-ansible-tempest-multinode SUCCESS in 1h 44m 02s
✔️ edpm-ansible-molecule-edpm_bootstrap SUCCESS in 8m 21s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 7m 01s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 57s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 08s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 10m 35s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 12m 11s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 8m 57s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 6m 20s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 8m 01s
✔️ edpm-ansible-molecule-edpm_ovs SUCCESS in 13m 32s
✔️ edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 4m 25s
✔️ edpm-ansible-molecule-edpm_tuned SUCCESS in 6m 57s
✔️ edpm-ansible-molecule-edpm_telemetry_power_monitoring SUCCESS in 8m 19s
adoption-standalone-to-crc-ceph-provider FAILURE in 1h 44m 21s

The options added to the ovn-ctl commands used to create local OVN NB
and SB DBs when TLS was enabled were wrong.
With this PR, the correct options are used instead.

Jira: OSPRH-11428
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c8eb5263448f4d15889858f32b8838bf

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 40m 07s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 40s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 40m 29s
edpm-ansible-tempest-multinode FAILURE in 29m 43s
✔️ edpm-ansible-molecule-edpm_bootstrap SUCCESS in 6m 02s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 4m 42s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 15s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 7m 18s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 8m 04s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 8m 33s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 6m 01s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 4m 04s
✔️ edpm-ansible-molecule-edpm_ovn_bgp_agent SUCCESS in 6m 36s
✔️ edpm-ansible-molecule-edpm_ovs SUCCESS in 12m 05s
✔️ edpm-ansible-molecule-edpm_tripleo_cleanup SUCCESS in 3m 29s
✔️ edpm-ansible-molecule-edpm_tuned SUCCESS in 6m 09s
✔️ edpm-ansible-molecule-edpm_telemetry_power_monitoring SUCCESS in 6m 08s
adoption-standalone-to-crc-ceph-provider FAILURE in 2h 08m 01s

@eduolivares
Copy link
Contributor Author

recheck

@eduolivares eduolivares merged commit 998ae17 into openstack-k8s-operators:main Nov 16, 2024
34 of 35 checks passed
@eduolivares
Copy link
Contributor Author

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@eduolivares: new pull request created: #818

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants