Inject user provided nft rules #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
bshephar
force-pushed
the
nftables-user-var
branch
5 times, most recently
from
015dcb1 to
8d227c7
Compare
|
Looks good to me. |
rabi
reviewed
Nov 13, 2024
| - name: "Ensure we drop connections on TCP/1211" | ||
| lineinfile: | ||
| path: /etc/nftables/edpm-rules.nft | ||
| line: 'add rule inet filter EDPM_INPUT tcp dport { 1211 } ct state new counter drop comment "010 testing action"' | ||
| register: line_in_file | ||
|
|
There was a problem hiding this comment.
There is genuine pre-commit job failure with spaces here.
bshephar
force-pushed
the
nftables-user-var
branch
from
8d227c7 to
2dd62ff
Compare
|
recheck |
slagle
approved these changes
Nov 15, 2024
bshephar
force-pushed
the
nftables-user-var
branch
from
2dd62ff to
a1fc9f2
Compare
This change ensures that user provided rules are injected into the edpm_nftables_src directory and loaded during rule generation. The change adds a new variable to facilitate a user interface for rule injection edpm_nftables_user_rules. Signed-off-by: Brendan Shephard <[email protected]>
Signed-off-by: Brendan Shephard <[email protected]>
bshephar
force-pushed
the
nftables-user-var
branch
from
a1fc9f2 to
08722fa
Compare
fao89
approved these changes
Nov 19, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, fao89, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit b261ece
into
openstack-k8s-operators:main
35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that user provided rules are injected into the edpm_nftables_src directory and loaded during rule generation.
The change adds a new variable to facilitate a user interface for rule injection edpm_nftables_user_rules.
Jira: https://issues.redhat.com/browse/OSPRH-11347