Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make env_data role compliant with ansible-lint production profile #443

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Make env_data role compliant with ansible-lint production profile #443

merged 1 commit into from
Oct 13, 2023

Conversation

rebtoor
Copy link
Contributor

@rebtoor rebtoor commented Oct 11, 2023

  • Fixed indentation issues
  • Added changed_when/failed_when in command task

@rebtoor
Make env_data role compliant with ansible-lint production profile
e0fb55c 
- Fixed indentation issues
- Added `changed_when`/`failed_when` in `command` task

Signed-off-by: Roberto Alfieri <[email protected]>
@rebtoor rebtoor requested a review from jpodivin October 11, 2023 14:57
@openshift-ci openshift-ci bot requested review from fao89 and fultonj October 11, 2023 14:57
@openshift-ci openshift-ci bot added the lgtm label Oct 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fao89, rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/2b0b62ea6b734b4d9cbb324bcfadd7bd

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 11m 05s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 48m 37s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 30m 55s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 53s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 6m 22s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 56s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 7m 04s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 7m 07s

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 12, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/40341f89a9704e97be34a1e88be50f1c

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 08s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 31m 25s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 00m 06s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 03s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 59s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 36s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 23s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 04s

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 13, 2023

recheck

@openshift-ci openshift-ci bot merged commit 046e93b into openstack-k8s-operators:main Oct 13, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fao89 fao89 fao89 approved these changes

@jpodivin jpodivin Awaiting requested review from jpodivin

@fultonj fultonj Awaiting requested review from fultonj

Assignees

@fao89 fao89

Labels
approved enforce-production-linting-profile lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rebtoor @fao89