Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make edpm_users role compliant with ansible-lint production profile #442

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Make edpm_users role compliant with ansible-lint production profile #442

merged 1 commit into from
Oct 16, 2023

Conversation

rebtoor
Copy link
Contributor

@rebtoor rebtoor commented Oct 11, 2023

  • Fixed indentation issues
  • Capitalized first letter in the task names
  • Moved templating to the end of task names

@rebtoor
Make edpm_users role compliant with ansible-lint production profile
30b1091 
- Fixed indentation issues
- Capitalized first letter in the task names
- Moved templating to the end of task names

Signed-off-by: Roberto Alfieri <[email protected]>
@rebtoor rebtoor requested a review from SeanMooney October 11, 2023 14:45
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d9305da831c3401e8e059dc761c6680a

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 03m 59s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 46m 12s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 12s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 7m 01s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 31s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 15s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 49s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 7m 15s

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 13, 2023

recheck

@openshift-ci openshift-ci bot added the lgtm label Oct 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpodivin, rebtoor, SeanMooney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SeanMooney,jpodivin,rebtoor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit e43d6f5 into openstack-k8s-operators:main Oct 16, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpodivin jpodivin jpodivin approved these changes

@SeanMooney SeanMooney SeanMooney approved these changes

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday

@fultonj fultonj Awaiting requested review from fultonj

Assignees

@SeanMooney SeanMooney

@jpodivin jpodivin

Labels
approved enforce-production-linting-profile lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rebtoor @SeanMooney @jpodivin