Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make edpm_telemetry role compliant with ansible-lint production profile #439

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Make edpm_telemetry role compliant with ansible-lint production profile #439

merged 1 commit into from
Oct 16, 2023

Conversation

rebtoor
Copy link
Contributor

@rebtoor rebtoor commented Oct 11, 2023

  • Fixed spacing issue
  • Declared dicts in loop using long form to avoid line > 160 characters

@rebtoor
Make edpm_telemetry role compliant with ansible-lint production p…
ebfe937 
…rofile

- Fixed spacing issue
- Declared dicts in loop using long form to avoid line > 160 characters

Signed-off-by: Roberto Alfieri <[email protected]>
@rebtoor rebtoor requested a review from jlarriba October 11, 2023 10:20
@openshift-ci openshift-ci bot requested review from dprince and lewisdenny October 11, 2023 10:20
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/0e65ae8064cc406693eaf3dd0b7ee8eb

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 37s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 6s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 31m 32s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 7m 02s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 37s
❌ edpm-ansible-molecule-edpm_kernel RETRY_LIMIT in 3s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 59s
❌ edpm-ansible-molecule-edpm_nova RETRY_LIMIT in 3s

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 11, 2023

recheck

retry_limit

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/6907c13127004af2bdfd698164d86cbd

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 55m 18s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 37m 59s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 30m 03s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 54s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 57s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 12m 44s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 31s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 14s

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 12, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/8fdb089d51ee4e0e8859ee57dbe83053

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 50m 12s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 36m 05s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 29m 05s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 15s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 28s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 56s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 03s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 5m 58s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 8m 09s

@lewisdenny
Copy link
Contributor

recheck
Due to a CI Blocker

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b1c71fc4fc8d45a3ba6fdb97fefd4db3

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 13m 56s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 37m 36s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 18m 14s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 43s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 03s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 22s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 31s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 32s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 7m 44s

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 14, 2023

recheck

@openshift-ci openshift-ci bot added the lgtm label Oct 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpodivin, rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 1f52108 into openstack-k8s-operators:main Oct 16, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpodivin jpodivin jpodivin approved these changes

@jlarriba jlarriba Awaiting requested review from jlarriba

@dprince dprince Awaiting requested review from dprince

@lewisdenny lewisdenny Awaiting requested review from lewisdenny

Assignees

@jpodivin jpodivin

Labels
approved enforce-production-linting-profile lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rebtoor @lewisdenny @jpodivin