Make edpm_sshd role compliant with ansible-lint production profile
#436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed `False` with `false` in the `argument_specs.yml` file - Replaced `'` with `"` in `mode` parameter for coherence with the rest of the repo - Added `changed_when`/`failed_when` in `command` task - Disabled `no-handler` linting check for `Generate sshd host keys` task Signed-off-by: Roberto Alfieri <[email protected]>
rebtoor
force-pushed
the
sshd_production_profile
branch
from
4ef1ca7 to
e66152c
Compare
jpodivin
approved these changes
Oct 11, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpodivin, rebtoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
merged commit 472ffaa
into
openstack-k8s-operators:main
22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Falsewithfalsein theargument_specs.ymlfile'with"inmodeparameter for coherence with the rest of the repochanged_when/failed_whenincommandtaskno-handlerlinting check forGenerate sshd host keystask