Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make edpm_nftables role compliant with ansible-lint production profile` #428

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Make edpm_nftables role compliant with ansible-lint production profile` #428

merged 1 commit into from
Oct 12, 2023

Conversation

rebtoor
Copy link
Contributor

@rebtoor rebtoor commented Oct 10, 2023

  • fixed linting issues in files/00-base-rules.yaml file
  • added changed_when/failed_when in command/shell tasks
  • replaced ' with " in mode parameter for coherence with the rest of the repo
  • added set -o pipefail in shell tasks where needed
  • replaced ignore_errors: true with failed_when
  • replaced systemctl usage in command tasks with service_facts and systemd modules

@openshift-ci openshift-ci bot requested review from dprince and stuggi October 10, 2023 09:23
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/7b7a98f4df2547898da7bf4f45888607

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 11m 38s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 51m 22s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 54m 41s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 24s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 54s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 12m 01s
❌ edpm-ansible-molecule-edpm_libvirt FAILURE in 5m 21s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 5m 49s

@rebtoor rebtoor force-pushed the nftables_production_profile branch from db528e6 to 9c5065a Compare October 10, 2023 13:18
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/ffe62ff42b954ac2a9e369524a1fdffe

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 31s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 19m 12s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 24m 55s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 08s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 25s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 48s
❌ edpm-ansible-molecule-edpm_libvirt FAILURE in 6m 05s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 25s

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 10, 2023

/hold

@openshift-ci openshift-ci bot added the lgtm label Oct 10, 2023
@rebtoor rebtoor force-pushed the nftables_production_profile branch from 9c5065a to 7da7ce7 Compare October 11, 2023 10:02
@openshift-ci openshift-ci bot removed the lgtm label Oct 11, 2023
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/bdbc29d1d8a14ae2b89baf929bb762c7

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 49m 46s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 27m 36s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 29m 49s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 7m 32s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 9m 25s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 14m 53s
❌ edpm-ansible-molecule-edpm_libvirt FAILURE in 5m 49s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 06s

@rebtoor
Make edpm_nftables role compliant with ansible-lint production pr…
0afb9c3 
…ofile

- fixed linting issues in `files/00-base-rules.yaml` file
- added `changed_when`/`failed_when` in `command`/`shell` tasks
- replaced `'` with `"` in `mode` parameter for coherence with the rest of the repo
- added `set -o pipefail` in `shell` tasks where needed
- replaced `ignore_errors: true` with `failed_when`
- replaced `systemctl` usage in `command` tasks with `service_facts` and `systemd` modules

Signed-off-by: Roberto Alfieri <[email protected]>
@rebtoor rebtoor force-pushed the nftables_production_profile branch from 7da7ce7 to 0afb9c3 Compare October 11, 2023 14:33
@rebtoor rebtoor requested a review from slagle October 11, 2023 14:33
@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 11, 2023

/unhold

@openshift-ci openshift-ci bot added the lgtm label Oct 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebtoor, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a74f53ac0d184e7aa8fc9a78daf1bc82

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 55m 22s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 38m 12s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 36m 42s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 15s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 18s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 50s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 10s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 7m 39s

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 12, 2023

recheck

@openshift-ci openshift-ci bot merged commit dadb122 into openstack-k8s-operators:main Oct 12, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slagle slagle slagle approved these changes

@dprince dprince Awaiting requested review from dprince

@stuggi stuggi Awaiting requested review from stuggi

Assignees

@slagle slagle

Labels
approved enforce-production-linting-profile lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rebtoor @slagle