Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make edpm_neutron_sriov role compliant with ansible-lint production profile #427

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Make edpm_neutron_sriov role compliant with ansible-lint production profile #427

merged 1 commit into from
Oct 10, 2023

Conversation

rebtoor
Copy link
Contributor

@rebtoor rebtoor commented Oct 9, 2023

  • Capitalized first letter of the task names
  • Fixed spacing issues
  • Changed yes to true
  • Fixed indentation
  • Changed mode parameter to be a string

@rebtoor
Make edpm_neutron_sriov role compliant with ansible-lint `productio…
6348762 
…n` profile

- Capitalized first letter of the task names
- Fixed spacing issues
- Changed boolean values to `true`/`false`
- Fixed indentation
- Changed `mode` parameter to be a string

Signed-off-by: Roberto Alfieri <[email protected]>
@rebtoor rebtoor requested review from booxter and slawqo October 9, 2023 14:31
@openshift-ci openshift-ci bot added the approved label Oct 9, 2023
@openshift-ci openshift-ci bot added the lgtm label Oct 9, 2023
@booxter
Copy link
Contributor

booxter commented Oct 9, 2023

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: booxter, rebtoor, slawqo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d8e20a2fe7c045f1ab537ba4456dbb48

❌ openstack-k8s-operators-content-provider RETRY_LIMIT in 8s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
❌ edpm-ansible-molecule-edpm_podman RETRY_LIMIT in 4s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 37s
❌ edpm-ansible-molecule-edpm_kernel RETRY_LIMIT in 2s
❌ edpm-ansible-molecule-edpm_libvirt RETRY_LIMIT in 3s
❌ edpm-ansible-molecule-edpm_nova RETRY_LIMIT in 2s

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 9, 2023

recheck

Retry_limit

@openshift-ci openshift-ci bot merged commit 6d2e781 into openstack-k8s-operators:main Oct 10, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawqo slawqo slawqo approved these changes

@booxter booxter Awaiting requested review from booxter

Assignees

@slawqo slawqo

Labels
approved enforce-production-linting-profile lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rebtoor @booxter @slawqo