Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ovn: don't explicitly set vlan-limit=0 #425

Merged
merged 1 commit into from
Oct 30, 2023
Merged

ovn: don't explicitly set vlan-limit=0 #425

merged 1 commit into from
Oct 30, 2023

Conversation

booxter
Copy link
Contributor

@booxter booxter commented Oct 9, 2023

ovn-controller does it automatically since 21.09.0 [1].

ovn-org/ovn@7e2c892

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 9, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved label Oct 9, 2023
@booxter booxter marked this pull request as ready for review October 9, 2023 13:58
@openshift-ci openshift-ci bot requested review from karelyatin and slawqo October 9, 2023 13:58
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/b2d19cbeae7f4c42a5f0dcaa86f1434b

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 25m 29s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 49m 01s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 44m 53s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 55s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 18s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 25s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 22s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 24s

@slawqo
Copy link
Contributor

slawqo commented Oct 24, 2023

Please rebase it to resolve conflicts and then it's LGTM for me :)

@booxter
ovn: don't explicitly set vlan-limit=0
3098cfe 
ovn-controller does it automatically since 21.09.0 [1].

This patch also gracefully handles a case where external_ids passed as
variable are empty, if it ever happens.

ovn-org/ovn@7e2c892
@booxter booxter requested a review from karelyatin October 30, 2023 14:47
karelyatin
karelyatin approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@karelyatin karelyatin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 30, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: booxter, karelyatin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit b3354bd into openstack-k8s-operators:main Oct 30, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karelyatin karelyatin karelyatin approved these changes

@slawqo slawqo Awaiting requested review from slawqo

Assignees

@karelyatin karelyatin

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@booxter @slawqo @karelyatin @openshift-merge-robot