install systemd-containerd on all edpm hosts as part of bootstrap #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systemd-containerd is required to allow libvirt to manage cgroups for qemu instance across container restarts. Without systemd-container libvirt falls back to a legacy code path where it directly manages cgroups without registering vms in systemd-machined. This is nolonger tested by libvirt team downstream and is known to cause issues with podman. We solve this requirement by installing the package in the bootstrap role to ensure its alwasy installed on edpm hosts.
SeanMooney
force-pushed
the
systemd-cotainer
branch
from
6c872a3 to
892ad1a
Compare
bogdando
approved these changes
Oct 5, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bogdando, SeanMooney The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
merged commit 471add2
into
openstack-k8s-operators:main
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
systemd-container is required to allow libvirt to manage cgroups
for qemu instance across container restarts.
Without systemd-container libvirt falls back to a legacy code
path where it directly manages cgroups without registering
vms in systemd-machined. This is nolonger tested by libvirt team
downstream and is known to cause issues with podman.
We solve this requirement by installing the package in the bootstrap
role to ensure its always installed on edpm hosts.