Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure logrotate image is also pre-downloaded #389

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

luis5tb
Copy link
Contributor

@luis5tb luis5tb commented Oct 4, 2023

No description provided.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 4, 2023

Hi @luis5tb. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fao89
Copy link
Contributor

fao89 commented Oct 4, 2023

/ok-to-test

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/443c0174b9204c189737107cb912f883

✔️ openstack-k8s-operators-content-provider SUCCESS in 41m 02s
podified-multinode-edpm-deployment-crc RETRY_LIMIT in 17m 49s
cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 22m 32s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 35s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 52s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 52s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 27s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 36s

@openshift-ci openshift-ci bot removed the lgtm label Oct 4, 2023
@luis5tb luis5tb changed the title Ensure logrotate image is also pre-downloaded [WIP] Ensure logrotate image is also pre-downloaded Oct 4, 2023
@luis5tb
Copy link
Contributor Author

luis5tb commented Oct 4, 2023

still testing this as it is not working as expected

@luis5tb luis5tb changed the title [WIP] Ensure logrotate image is also pre-downloaded Ensure logrotate image is also pre-downloaded Oct 4, 2023
@luis5tb
Copy link
Contributor Author

luis5tb commented Oct 4, 2023

now it is working

Copy link
Contributor

@rebtoor rebtoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edpm_logrotate_crond is already in the download_cache: #338

@luis5tb
Copy link
Contributor Author

luis5tb commented Oct 4, 2023

edpm_logrotate_crond is already in the download_cache: #338

but that is only for the packages, not for the container image

@rebtoor
Copy link
Contributor

rebtoor commented Oct 4, 2023

edpm_logrotate_crond is already in the download_cache: #338

but that is only for the packages, not for the container image

Oh, sorry, you're right. I'll leave you a review just to change a bit in the download task. (I saw that you already solved the merge issue, thanks!)

@luis5tb luis5tb requested review from rebtoor and jpodivin October 5, 2023 07:54
@openshift-ci openshift-ci bot added the lgtm label Oct 5, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpodivin, luis5tb, rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit 19ed55e into openstack-k8s-operators:main Oct 5, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants