-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure logrotate image is also pre-downloaded #389
Conversation
Hi @luis5tb. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/443c0174b9204c189737107cb912f883 ✔️ openstack-k8s-operators-content-provider SUCCESS in 41m 02s |
still testing this as it is not working as expected |
now it is working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edpm_logrotate_crond is already in the download_cache: #338
but that is only for the packages, not for the container image |
Oh, sorry, you're right. I'll leave you a review just to change a bit in the download task. (I saw that you already solved the merge issue, thanks!) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpodivin, luis5tb, rebtoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
19ed55e
into
openstack-k8s-operators:main
No description provided.